Skip to content

Use p3 recursive pow compression #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kilic wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use p3 recursive pow compression #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@ cast_sign_loss = "allow"
[dependencies]
serde = { version = "1.0", features = ["derive"] }
rayon = { version = "1.0", optional = true }
p3-field = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-baby-bear = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-koala-bear = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-merkle-tree = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-symmetric = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-matrix = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-commit = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-goldilocks = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-dft = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-util = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-maybe-rayon = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016", features = [
p3-field = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-baby-bear = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-koala-bear = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-merkle-tree = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-symmetric = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-matrix = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-commit = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-goldilocks = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-dft = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-util = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-maybe-rayon = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress", features = [
] }
p3-interpolation = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-challenger = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-multilinear-util = { git = "https://github.com/Plonky3/Plonky3.git", rev = "f742016" }
p3-interpolation = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-challenger = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }
p3-multilinear-util = { git = "https://github.com/kilic/Plonky3.git", branch = "recursive-pow-compress" }

itertools = "0.14"
thiserror = "2.0"
Expand Down
60 changes: 3 additions & 57 deletions src/whir/constraints/statement/select.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use p3_field::{ExtensionField, Field, dot_product};
use p3_maybe_rayon::prelude::*;
use p3_multilinear_util::eq_batch::eval_pow_batch_base;
use tracing::instrument;

use crate::poly::evals::EvaluationsList;
Expand Down Expand Up @@ -114,67 +114,13 @@ impl<F: Field, EF: ExtensionField<F>> SelectStatement<F, EF> {

// Number of constraints (columns).
let n = self.len();
// Number of variables (bits).
let k = self.num_variables();

// v0^(2^0), v0^(2^1), ..., v0^(2^{k-1})
// v1^(2^0), v1^(2^1), ..., v1^(2^{k-1})
let bin_powers = self
.vars
.par_iter()
.copied()
.map(|mut var| {
(0..k)
.map(|_| {
let ret = var;
var = var.square();
ret
})
.collect::<Vec<_>>()
})
.collect::<Vec<_>>();

// Equality matrix.
let mut acc: Vec<F> = F::zero_vec((1 << k) * n);

// Initialize row 0 with 1s. We will apply randomness later
acc[..n].copy_from_slice(&vec![F::ONE; n]);

// Expand row 0 into 2^k rows with a simple two-branch split per bit.
// `high = low * z`
// Here z ∈ {0,1} is the i-th coordinate of the constraint point.
for i in 0..k {
// Split the first 2^i rows into low and high halves in place.
let (lo, hi) = acc.split_at_mut((1 << i) * n);

// Fetch binary powers for the current round
let bin_powers = bin_powers.iter().map(|c| c[i]).collect::<Vec<_>>();

// Work in parallel over row pairs. Each pair has n columns.
lo.par_chunks_mut(n)
.zip(hi.par_chunks_mut(n))
.for_each(|(lo, hi)| {
// For each column j: read its constraint point, update the pair.
bin_powers
.iter()
.zip(lo.iter_mut())
.zip(hi.iter_mut())
.for_each(|((&z, lo), hi)| *hi = *lo * z);
});
}

// Precompute γ^i for i = 0..n-1 (random linear-combination weights).
let challenges = challenge.powers().skip(shift).take(n).collect::<Vec<_>>();

acc.par_chunks(n)
.zip(acc_weights.0.par_iter_mut())
.for_each(|(row, out)| {
*out += row
.iter()
.zip(challenges.iter())
.fold(EF::ZERO, |acc, (&v, &alpha)| acc + alpha * v);
});
eval_pow_batch_base::<F, EF, true>(&self.vars, &mut acc_weights.0, challenges.as_slice());

// Combine expected evaluations: S = ∑_i γ^i * s_i
*acc_sum +=
dot_product::<EF, _, _>(challenges.into_iter(), self.evaluations.iter().copied());
}
Expand Down