Serializing transcript #402
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a global and serializing transcript and removes
WhirProofCurrently in a fiat shamir stream, a mutable proof object and a p3-challenger has to move and operate together. New transcript object wraps them into single object
FiatShamirWriterfor prover side andFiatShamirReaderfor verifier side. New transcript immediately serializes (or deserialize) elements in proof so it should work with any kind of proof stream. For future improvements we can add IO pattern enforcement.