Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroProj fix & small optimization #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

zeroProj fix & small optimization #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a943121
small optimization
Arvolear Nov 4, 2024
5cf8fa5
fix zero proj
Arvolear Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions contracts/curves/EllipticCurve.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ contract EllipticCurve {
function zeroProj() public pure
returns (uint x, uint y, uint z)
{
return (0, 1, 0);
return (0, 0, 1);
}

/**
Expand Down Expand Up @@ -297,7 +297,7 @@ contract EllipticCurve {
uint base2Y = y0;
uint base2Z = 1;

for(uint i = 0; i < exp; i++) {
for(uint i = 0; i < exp; ++i) {
(base2X, base2Y, base2Z) = twiceProj(base2X, base2Y, base2Z);
}

Expand Down Expand Up @@ -327,7 +327,7 @@ contract EllipticCurve {
x1 = x0;
y1 = y0;

if(scalar%2 == 0) {
if(scalar & 1 == 0) {
x1 = y1 = 0;
}

Expand All @@ -336,7 +336,7 @@ contract EllipticCurve {
while(scalar > 0) {
(base2X, base2Y, base2Z) = twiceProj(base2X, base2Y, base2Z);

if(scalar%2 == 1) {
if(scalar & 1 == 1) {
(x1, y1, z1) = addProj(base2X, base2Y, base2Z, x1, y1, z1);
}

Expand Down Expand Up @@ -374,19 +374,14 @@ contract EllipticCurve {
uint x2;
uint y1;
uint y2;
uint px;
uint py;

uint sInv = inverseMod(rs[1], n);
(x1, y1) = multiplyScalar(gx, gy, mulmod(uint(message), sInv, n));
(x2, y2) = multiplyScalar(Q[0], Q[1], mulmod(rs[0], sInv, n));
uint[3] memory P = addAndReturnProjectivePoint(x1, y1, x2, y2);
(px, py) = add(x1, y1, x2, y2);

if (P[2] == 0) {
return false;
}

uint Px = inverseMod(P[2], p);
Px = mulmod(P[0], mulmod(Px, Px, p), p);

return Px % n == rs[0];
return px == rs[0];
}
}
}