Skip to content

๐Ÿ”€ :: #182 ๋ฐ”ํ…€์‹œํŠธ ํ›„๊ธฐ ์‚ญ์ œ ํ๋ฆ„ ๋ฐ ํ•ธ๋“ค ํ„ฐ์น˜ ์˜์—ญ ๊ฐœ์„  - #183

Merged
minsun-0209 merged 3 commits into
devfrom
182-fix/bottomsheet-delete-flow
Apr 22, 2026
Merged

๐Ÿ”€ :: #182 ๋ฐ”ํ…€์‹œํŠธ ํ›„๊ธฐ ์‚ญ์ œ ํ๋ฆ„ ๋ฐ ํ•ธ๋“ค ํ„ฐ์น˜ ์˜์—ญ ๊ฐœ์„ #183
minsun-0209 merged 3 commits into
devfrom
182-fix/bottomsheet-delete-flow

Conversation

@juunpy0

@juunpy0 juunpy0 commented Apr 22, 2026

Copy link
Copy Markdown
Member

๐ŸŽ ๊ฐœ์š”

๋ฐ”ํ…€์‹œํŠธ ํ›„๊ธฐ ์‚ญ์ œ ์‹œ UI๊ฐ€ ์•Œ๋Ÿฟ ์ด์ „์— ๋จผ์ € ๋ฐ˜์˜๋˜๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•˜๊ณ ,
ํ•ธ๋“ค ํ„ฐ์น˜ ์˜์—ญ์„ ํ™•์žฅํ•˜์—ฌ ๋“œ๋ž˜๊ทธ UX๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ฆ ์ž‘์—… ๋‚ด์šฉ

1. ๋ฐ”ํ…€์‹œํŠธ ํ›„๊ธฐ ์‚ญ์ œ ๋กœ์ง ์ˆ˜์ •

  • ์‚ญ์ œ ๋ฒ„ํŠผ ํด๋ฆญ ์‹œ UI๊ฐ€ ๋จผ์ € ๋ฐ˜์˜๋˜๋˜ ๋ฌธ์ œ ์ˆ˜์ •
  • BottomSheet์—์„œ ์ง์ ‘ ๋ฐ์ดํ„ฐ ์ œ๊ฑฐํ•˜๋˜ ๋กœ์ง ์ œ๊ฑฐ
  • ์‚ญ์ œ๋Š” ViewController โ†’ API ์„ฑ๊ณต ์ดํ›„ โ†’ UI ๊ฐฑ์‹  ํ๋ฆ„์œผ๋กœ ๋ณ€๊ฒฝ

2. ๋ฐ”ํ…€์‹œํŠธ ํ•ธ๋“ค ํ„ฐ์น˜ ์˜์—ญ ๊ฐœ์„ 

  • ํ•ธ๋“ค ์˜์—ญ์ด ์ž‘์•„ ๋“œ๋ž˜๊ทธ๊ฐ€ ์–ด๋ ค์šด ๋ฌธ์ œ ์ˆ˜์ •
  • handleTouchArea๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ„ฐ์น˜ ์˜์—ญ ํ™•์žฅ
  • ๋“œ๋ž˜๊ทธ ์ œ์Šค์ฒ˜ ์ธ์‹ ๊ฐœ์„ 

@juunpy0 juunpy0 self-assigned this Apr 22, 2026
@juunpy0 juunpy0 added ๐ŸŽจ UI ๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—… labels Apr 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a touch handle area to the map bottom sheet and updates layout constants. The review feedback identifies that the bottomSheetHandleTouchArea in the view controller is redundant and may block map interactions when the sheet is hidden. It is recommended to remove this redundant view and its associated constraints and gestures. Additionally, the firstHeight constant should be increased to 48 to prevent layout clipping, and minor whitespace cleanup is needed in the bottom sheet view.

Comment thread Projects/Feature/Sources/Scene/Map/View/MapViewController.swift
Comment thread Projects/Feature/Sources/Scene/Map/View/MapViewController.swift
Comment thread Projects/Feature/Sources/Scene/Map/View/MapViewController.swift
Comment thread Projects/Feature/Sources/Scene/Map/View/MapViewController.swift
Comment thread Projects/Feature/Sources/Scene/Map/View/MapViewController.swift
Comment thread Projects/Feature/Sources/Scene/Map/View/MapBottomSheetView.swift
@minsun-0209
minsun-0209 merged commit 8c6f51e into dev Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—… ๐ŸŽจ UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants