๐ :: #182 ๋ฐํ ์ํธ ํ๊ธฐ ์ญ์ ํ๋ฆ ๋ฐ ํธ๋ค ํฐ์น ์์ญ ๊ฐ์ - #183
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a touch handle area to the map bottom sheet and updates layout constants. The review feedback identifies that the bottomSheetHandleTouchArea in the view controller is redundant and may block map interactions when the sheet is hidden. It is recommended to remove this redundant view and its associated constraints and gestures. Additionally, the firstHeight constant should be increased to 48 to prevent layout clipping, and minor whitespace cleanup is needed in the bottom sheet view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ ๊ฐ์
๋ฐํ ์ํธ ํ๊ธฐ ์ญ์ ์ UI๊ฐ ์๋ฟ ์ด์ ์ ๋จผ์ ๋ฐ์๋๋ ๋ฌธ์ ๋ฅผ ์์ ํ๊ณ ,
ํธ๋ค ํฐ์น ์์ญ์ ํ์ฅํ์ฌ ๋๋๊ทธ UX๋ฅผ ๊ฐ์ ํ์ต๋๋ค.
๐ฆ ์์ ๋ด์ฉ
1. ๋ฐํ ์ํธ ํ๊ธฐ ์ญ์ ๋ก์ง ์์
2. ๋ฐํ ์ํธ ํธ๋ค ํฐ์น ์์ญ ๊ฐ์