Skip to content

193 feature profile fix - #194

Merged
juunpy0 merged 8 commits into
devfrom
193-feature-profile-fix
Jun 15, 2026
Merged

193 feature profile fix#194
juunpy0 merged 8 commits into
devfrom
193-feature-profile-fix

Conversation

@minsun-0209

Copy link
Copy Markdown
Collaborator

🍎 개요

  • 프로필 정보를 변경한 후 메인 화면으로 돌아왔을 때 실시간으로 반영되지 않고 기존 데이터가 그대로 남아있던 문제를 해결했습니다.

📦 작업 내용

  • 프로필 변경 이벤트 감지 및 메인 화면 데이터 동기화 로직 구현
  • 메인 화면 진입또는 관련 프로필 변경 알림 발생 시 프로필 카드가 실시간으로 갱신되도록 처리
  • UI 레이아웃 정렬 및 가독성 개선

🔄 :: #193

@minsun-0209 minsun-0209 self-assigned this Jun 15, 2026
@minsun-0209 minsun-0209 added 🧨 Bug 정상 동작하지 않는 기능의 오류를 수정하는 작업 💄 Fix 기존 기능의 버그 수정 또는 UI/텍스트 등 개선 작업 labels Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces layout improvements, flickering prevention, and better data synchronization when updating profile information. Specifically, it refactors constraints in UserProfileViewController to prevent text truncation, adds a custom initializer to pre-populate profile data, and adjusts MainViewController to reload data when removing the profile overlay. The review feedback highlights a redundant network request in viewWillAppear where fetchData() is called alongside individual fetch methods, suggests refactoring duplicate layout code for latecomerLabel using a ternary operator, and recommends utilizing the new init(initialProfile:) initializer when presenting the profile view controller to prevent initial loading flickering.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@juunpy0
juunpy0 merged commit 79404ee into dev Jun 15, 2026
1 check passed
@minsun-0209
minsun-0209 deleted the 193-feature-profile-fix branch July 7, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧨 Bug 정상 동작하지 않는 기능의 오류를 수정하는 작업 💄 Fix 기존 기능의 버그 수정 또는 UI/텍스트 등 개선 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants