Skip to content

๐Ÿ› - fix :: ์ง€๊ฐ์ž ๋ช…๋‹จ ์กฐํšŒ ์‹œ ๋‹น์ผ ๋‚ ์งœ ๋ฏธ๋ฐ˜์˜ ๋ฐ ๊ณ„์‚ฐ ์˜ค๋ฅ˜ ์ˆ˜์ • - #197

Merged
minsun-0209 merged 2 commits into
devfrom
196-feature-latecomer-date-fix
Jul 7, 2026

Conversation

@minsun-0209

Copy link
Copy Markdown
Collaborator

๐ŸŽ ๊ฐœ์š”

  • ์ง€๊ฐ์ž ๋ช…๋‹จ ์กฐํšŒ ์‹œ ๋‚ ์งœ ๊ณ„์‚ฐ ์˜ค๋ฅ˜๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ฆ ์ž‘์—… ๋‚ด์šฉ

  • LetecomerViewModel ๋‚ด ๊ธฐ์กด ๊ณ ์ • ๋‚ ์งœ(lastWednesday()) ๋กœ์ง ์ œ๊ฑฐ
  • ์•ฑ ์ง„์ž… ์‹œ์ ์˜ ๋‹น์ผ ๋‚ ์งœ(Date())๋ฅผ ๊ธฐ์ค€์œผ๋กœ API๋ฅผ ํ˜ธ์ถœํ•˜๋„๋ก ๋ณ€๊ฒฝ

๐Ÿ”€ :: #196

@minsun-0209 minsun-0209 self-assigned this Jun 17, 2026
@minsun-0209 minsun-0209 added the ๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—… label Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the date initialization in LetecomerViewModel by formatting the current date directly instead of calculating the last Wednesday. The reviewer recommends setting the locale of the DateFormatter to en_US_POSIX to prevent formatting issues caused by varying device settings, which could lead to API request failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@minsun-0209
minsun-0209 merged commit 6aae941 into dev Jul 7, 2026
1 check passed
@minsun-0209
minsun-0209 deleted the 196-feature-latecomer-date-fix branch July 7, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—…

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant