Skip to content

198 feature admin outing - #199

Merged
juunpy0 merged 3 commits into
devfrom
198-feature-admin-outing
Jul 7, 2026
Merged

198 feature admin outing#199
juunpy0 merged 3 commits into
devfrom
198-feature-admin-outing

Conversation

@minsun-0209

Copy link
Copy Markdown
Collaborator

🍎 개요

  • 학생 관리 페이지의 권한 변경 바텀시트에서 학생회 권한을 가진 유저를 조회할 때, 강제 외출/복귀 토글 보여지게 수정

📦 작업 내용

  • AuthorityBottomSheetVCsetupData() 메서드에서 forceOutingContainer 숨김 조건 수정
  • 기존에는 학생회 권한(ROLE_STUDENT_COUNCIL)일 때도 토글이 숨겨지도록 잘못 처리되어 있던 조건을 제거
  • 이제 일반 학생과 동일하게 블랙리스트 유저(isBlackList)가 아닌 경우, 학생회 권한 유저도 강제 외출/복귀 토글이 정상적으로 노출

🔀 :: #198

@minsun-0209
minsun-0209 requested a review from Copilot July 7, 2026 03:05
@minsun-0209 minsun-0209 self-assigned this Jul 7, 2026
@minsun-0209 minsun-0209 added 💡 Feature 기능 개발 💄 Fix 기존 기능의 버그 수정 또는 UI/텍스트 등 개선 작업 labels Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for unit test targets in Tuist project generation by adding a testSources parameter to the project template and configuring it for the Feature project. Additionally, it simplifies the visibility logic of forceOutingContainer in AuthorityBottomSheetVC. The review feedback warns that defining testSources without any matching test files will cause tuist generate to fail, and suggests ensuring at least one test file exists or deferring the configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Projects/Feature/Project.swift Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #198 by updating the Student Management authority change bottom sheet so that users with student council authority can see the force outing/return toggle (unless they are blacklisted). It also introduces optional unit test target generation support in the Tuist module template and applies it to the Feature module.

Changes:

  • Show forceOutingContainer for ROLE_STUDENT_COUNCIL users when they are not blacklisted.
  • Extend Project.makeModule(...) to optionally generate a \(name)Tests unit test target when testSources is provided.
  • Configure the Feature module to include Tests/** as testSources.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Tuist/ProjectDescriptionHelpers/Project+Templates.swift Adds optional testSources to generate a unit test target alongside the main target.
Projects/Feature/Sources/StudentManagement/BottomSheet/AuthorityBottomSheetVC.swift Adjusts hiding condition so the force outing UI is shown for student council users unless blacklisted.
Projects/Feature/Project.swift Opts Feature module into the new test target generation via testSources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Projects/Feature/Project.swift Outdated
Comment thread Tuist/ProjectDescriptionHelpers/Project+Templates.swift Outdated
@minsun-0209
minsun-0209 force-pushed the 198-feature-admin-outing branch from 11e973a to 1ff2b42 Compare July 7, 2026 03:11
@juunpy0
juunpy0 merged commit 8d683d9 into dev Jul 7, 2026
1 check passed
@minsun-0209
minsun-0209 deleted the 198-feature-admin-outing branch July 7, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 Feature 기능 개발 💄 Fix 기존 기능의 버그 수정 또는 UI/텍스트 등 개선 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants