198 feature admin outing - #199
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for unit test targets in Tuist project generation by adding a testSources parameter to the project template and configuring it for the Feature project. Additionally, it simplifies the visibility logic of forceOutingContainer in AuthorityBottomSheetVC. The review feedback warns that defining testSources without any matching test files will cause tuist generate to fail, and suggests ensuring at least one test file exists or deferring the configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #198 by updating the Student Management authority change bottom sheet so that users with student council authority can see the force outing/return toggle (unless they are blacklisted). It also introduces optional unit test target generation support in the Tuist module template and applies it to the Feature module.
Changes:
- Show
forceOutingContainerforROLE_STUDENT_COUNCILusers when they are not blacklisted. - Extend
Project.makeModule(...)to optionally generate a\(name)Testsunit test target whentestSourcesis provided. - Configure the Feature module to include
Tests/**astestSources.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Tuist/ProjectDescriptionHelpers/Project+Templates.swift |
Adds optional testSources to generate a unit test target alongside the main target. |
Projects/Feature/Sources/StudentManagement/BottomSheet/AuthorityBottomSheetVC.swift |
Adjusts hiding condition so the force outing UI is shown for student council users unless blacklisted. |
Projects/Feature/Project.swift |
Opts Feature module into the new test target generation via testSources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
11e973a to
1ff2b42
Compare
🍎 개요
📦 작업 내용
AuthorityBottomSheetVC내setupData()메서드에서forceOutingContainer숨김 조건 수정ROLE_STUDENT_COUNCIL)일 때도 토글이 숨겨지도록 잘못 처리되어 있던 조건을 제거isBlackList)가 아닌 경우, 학생회 권한 유저도 강제 외출/복귀 토글이 정상적으로 노출🔀 :: #198