Skip to content

๐Ÿ”€ :: #200 FCM ํ‘ธ์‹œ ์•Œ๋ฆผ ์—ฐ๋™ ๋ฐ ์•ฑ ์•„์ด์ฝ˜ ์„ค์ • - #204

Merged
minsun-0209 merged 2 commits into
devfrom
200-fix/password-regex-asterisk
Jul 12, 2026
Merged

๐Ÿ”€ :: #200 FCM ํ‘ธ์‹œ ์•Œ๋ฆผ ์—ฐ๋™ ๋ฐ ์•ฑ ์•„์ด์ฝ˜ ์„ค์ •#204
minsun-0209 merged 2 commits into
devfrom
200-fix/password-regex-asterisk

Conversation

@juunpy0

@juunpy0 juunpy0 commented Jul 10, 2026

Copy link
Copy Markdown
Member

๐ŸŽ ๊ฐœ์š”

  • FCM ํ‘ธ์‹œ ์•Œ๋ฆผ ์—ฐ๋™ ๋ฐ ์•ฑ ์•„์ด์ฝ˜ ์„ค์ •

๐Ÿ“ฆ ์ž‘์—… ๋‚ด์šฉ

  • APNs entitlements ์„ค์ • (aps-environment: development)
  • GoogleService-Info.plist ์˜ฌ๋ฐ”๋ฅธ ๋ฒˆ๋“ค ID(HARIBO.GOMS-iOS-V2)๋กœ ๊ต์ฒด ๋ฐ ํ…œํ”Œ๋ฆฟํ™”
  • Secrets.xcconfig ํ…œํ”Œ๋ฆฟ ์ถ”๊ฐ€
  • ์•ฑ ์•„์ด์ฝ˜ ์ „ ์‚ฌ์ด์ฆˆ ์ถ”๊ฐ€ (20~1024px)

@juunpy0
juunpy0 requested a review from minsun-0209 July 10, 2026 04:55
@juunpy0 juunpy0 self-assigned this Jul 10, 2026
@juunpy0 juunpy0 added the ๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—… label Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes hardcoded API keys and secrets (such as Kakao and Firebase keys) by introducing template configuration files (.xcconfig.template and GoogleService-Info.plist.template) and loading these values dynamically from Info.plist. The reviewer feedback highlights a critical issue where hardcoding aps-environment to development in the entitlements file will break push notifications in production environments. Additionally, the reviewer suggests using guard let statements with fatalError when loading the Kakao app and REST keys to catch configuration errors early during development.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Projects/App/Support/GOMS-iOS-V3.entitlements Outdated
Comment thread Projects/App/Sources/Application/AppDelegate.swift Outdated
Comment thread Projects/Service/Sources/Services/Map/PlaceServices.swift Outdated
@minsun-0209
minsun-0209 merged commit 60b5246 into dev Jul 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿ’„ Fix ๊ธฐ์กด ๊ธฐ๋Šฅ์˜ ๋ฒ„๊ทธ ์ˆ˜์ • ๋˜๋Š” UI/ํ…์ŠคํŠธ ๋“ฑ ๊ฐœ์„  ์ž‘์—…

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants