fix: 시간표 조회 API 스펙 변경(교육청/학교 코드 제거) 대응 - #201
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
requested review from
Dino0204,
g-hyxn,
hyooeunn,
jyuuuuu0,
ma94275 and
zaewc
July 6, 2026 11:41
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀이퀘스트에서는 neis.ts 모델에서 불필요한 NEIS_OFFICE_CODE 및 NEIS_SCHOOL_CODE 상수를 제거하고, Period 인터페이스의 teacher와 classroom 타입을 널러블(null) 및 문자열 타입으로 유연하게 변경하였습니다. 또한 TimetableParams와 TimeTableCard 컴포넌트에서 더 이상 사용되지 않는 officeCode 및 schoolCode 속성을 제거하여 코드를 정리했습니다. 해당 변경 사항에 대해 별도의 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Dino0204
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
없음
📝작업 내용
GET /v2/neis/timetables)가 NEIS 기반에서 DataGSM(DG) API 기반으로 변경되면서 삭제된officeCode,schoolCode파라미터를 클라이언트에서도 제거했습니다.Period응답 타입을 실제 서버 스펙(teacher: String?,classroom: String?)에 맞춰teacher,classroom을string | null로 수정했습니다.💬리뷰 요구사항