Skip to content

[REFACTOR] fetch join 적용 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehddbs4521 merged 3 commits into from
Sep 14, 2025
Merged

[REFACTOR] fetch join 적용 #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b33f42
fix: #236 resolve N+1 query issue with fetch join
ehddbs4521 Aug 28, 2025
912babd
fix: #236 add index on invitation code
ehddbs4521 Aug 28, 2025
5788071
refactor: #236 add fetch join
ehddbs4521 Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/doldol_server/doldol/rollingPaper/entity/Paper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class Paper extends BaseEntity {
@Column(name = "open_date", nullable = false)
private LocalDate openDate;

@Column(name = "invitation_code", nullable = false)
@Column(name = "invitation_code", unique = true, nullable = false)
private String invitationCode;

@Column(name = "participants_count")
Expand Down
7 changes: 5 additions & 2 deletions ...java/doldol_server/doldol/rollingPaper/repository/custom/MessageRepositoryCustomImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ public class MessageRepositoryCustomImpl implements MessageRepositoryCustom {
public MessageResponse getMessage(Long messageId, Long userId) {
QMessage message = QMessage.message;
QUser fromUser = new QUser("fromUser");
QUser toUser = new QUser("toUser");

Message result = queryFactory
.selectFrom(message)
.join(message.from, fromUser)
.join(message.from, fromUser).fetchJoin()
.join(message.to, toUser).fetchJoin()
.where(
message.id.eq(messageId),
message.from.id.eq(userId),
Expand All @@ -38,7 +40,7 @@ public MessageResponse getMessage(Long messageId, Long userId) {

MessageType messageType = MessageType.SEND;

return MessageResponse.of(result, result.getName(), result.getTo().getName(), messageType);
return MessageResponse.of(result, result.getFrom().getName(), result.getTo().getName(), messageType);
}

@Override
Expand Down Expand Up @@ -117,6 +119,7 @@ public List<MessageResponse> getSentMessages(Long paperId, Long userId, CursorPa
List<Message> messages = queryFactory
.selectFrom(message)
.join(message.from).fetchJoin()
.join(message.to).fetchJoin()
.where(
message.paper.id.eq(paperId),
message.from.id.eq(userId),
Expand Down
Loading