Skip to content

[REFACTOR] 로깅 수정 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehddbs4521 merged 2 commits into from
Sep 15, 2025
Merged

[REFACTOR] 로깅 수정 #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbcfce
refactor: #242 fix log truncation issue
ehddbs4521 Sep 15, 2025
bb9572e
refactor: #242 delete aop annotation
ehddbs4521 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/doldol_server/doldol/DoldolApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.openfeign.EnableFeignClients;
import org.springframework.context.annotation.EnableAspectJAutoProxy;

@EnableFeignClients
@EnableAspectJAutoProxy
@SpringBootApplication
public class DoldolApplication {

Expand Down
67 changes: 41 additions & 26 deletions src/main/java/doldol_server/doldol/common/config/LoggingAspect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
public class LoggingAspect {
private final ObjectMapper objectMapper = new ObjectMapper();

private static final String START_LOG = "================================================ERROR===============================================\n";
private static final String END_LOG = "================================================END===============================================\n";

@Pointcut("execution(* doldol_server.doldol.common.exception.GlobalExceptionHandler.handle*(..))")
public void controllerErrorLevelExecute() {
}
Expand All @@ -43,64 +40,82 @@ public Object requestErrorLevelLogging(ProceedingJoinPoint proceedingJoinPoint)
Object returnValue = proceedingJoinPoint.proceed(proceedingJoinPoint.getArgs());
long endAt = System.currentTimeMillis();

log.error(getCommunicationData(request, cachingRequest, startAt, endAt, returnValue, null));
logErrorDetails(request, cachingRequest, startAt, endAt, returnValue, null);
return returnValue;
}

private String getCommunicationData(
private void logErrorDetails(
HttpServletRequest request,
ContentCachingRequestWrapper cachingRequest,
long startAt,
long endAt,
Object returnValue,
Exception exception
) throws IOException {
StringBuilder sb = new StringBuilder();
) {
// 시작 구분선
log.error("================================================ERROR===============================================");

sb.append(START_LOG);
sb.append(String.format("====> Request: %s %s (%dms)\n====> Headers = %s\n",
// 기본 요청 정보
log.error("Request: {} {} ({}ms)",
request.getMethod(),
request.getRequestURL(),
endAt - startAt,
getHeaders(request)));
sb.append("====> Content-Type: ").append(request.getContentType()).append("\n");
endAt - startAt);

// 헤더 정보
Map<String, Object> headers = getHeaders(request);
log.error("Headers: {}", headers);

// Content-Type
log.error("Content-Type: {}", request.getContentType());

if ("POST".equalsIgnoreCase(request.getMethod()) && cachingRequest.getContentAsByteArray().length > 0) {
// POST 요청 Body 처리
if ("POST".equalsIgnoreCase(request.getMethod()) && cachingRequest != null) {
try {
sb.append(String.format("====> Body: %s\n", objectMapper.readTree(cachingRequest.getContentAsByteArray())));
byte[] content = cachingRequest.getContentAsByteArray();
if (content.length > 0) {
log.error("Body: {}", objectMapper.readTree(content));
} else {
log.error("Body: [Empty]");
}
} catch (Exception e) {
sb.append("====> Body: [Unable to parse JSON]\n");
log.error("Body: [Unable to parse JSON]");
}
}

// 응답 정보
if (returnValue != null) {
sb.append(String.format("====> Response: %s\n", returnValue));
log.error("Response: {}", returnValue);
}

// 예외 정보 (있는 경우)
if (exception != null) {
sb.append(String.format("====> Exception: %s\n", exception.getClass().getSimpleName()));
sb.append(String.format("====> Error Message: %s\n", exception.getMessage()));
log.error("Exception: {}", exception.getClass().getSimpleName());
log.error("Error Message: {}", exception.getMessage());

StackTraceElement[] stackTrace = exception.getStackTrace();
if (stackTrace.length > 0) {
sb.append("====> Stack Trace (top 5):\n");
log.error("Stack Trace (top 5):");
int limit = Math.min(5, stackTrace.length);
for (int i = 0; i < limit; i++) {
sb.append(String.format(" at %s\n", stackTrace[i].toString()));
log.error(" at {}", stackTrace[i].toString());
}
}
}

sb.append(END_LOG);
return sb.toString();
// 종료 구분선
log.error("================================================END===============================================");
}

private Map<String, Object> getHeaders(HttpServletRequest request) {
Map<String, Object> headerMap = new HashMap<>();
Enumeration<String> headerArray = request.getHeaderNames();
while (headerArray.hasMoreElements()) {
String headerName = headerArray.nextElement();
headerMap.put(headerName, request.getHeader(headerName));
try {
Enumeration<String> headerArray = request.getHeaderNames();
while (headerArray.hasMoreElements()) {
String headerName = headerArray.nextElement();
headerMap.put(headerName, request.getHeader(headerName));
}
} catch (Exception e) {
headerMap.put("error", "Unable to read headers: " + e.getMessage());
}
return headerMap;
}
Expand Down
Loading