[refactor] 주요 조회 API 응답 검증 및 데이터 흐름 개선 - #19
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request refactors API integration across multiple entities (dashboard, machine, report, reservation, and user) by introducing Zod schemas for robust runtime response validation and inferring TypeScript types directly from them. It also updates React Query hooks to utilize these schemas and refactored fetchers. The review feedback suggests improving import consistency by using double quotes in getReservations.ts, and optimizing performance by adding an enabled option to the useGetMachines hook so that machine data is only fetched in ReportsPage.tsx when a floor filter is actually selected.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
LeeSangHyeok0731
left a comment
There was a problem hiding this comment.
Gemini code assist 코멘트만 확인하시면 될 것 같습니다.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
개요 💡
작업내용 ⌨️
unknown으로 수신한 뒤 검증된 데이터만 Mapper와 UI에 전달penaltyExpiresAt의 nullable 타입 수정AdminLayout내부의 Dashboard 조회 로직을 entity Hook으로 이동