Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add github embeds #1037

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat(docs): add github embeds #1037

merged 1 commit into from
Sep 22, 2023

Conversation

jankal
Copy link
Contributor

@jankal jankal commented Sep 22, 2023

Replacing the non-functional emgithub script embeds with a custom react component to display content from GitHub files.

Implementation

External embeds of GitHub files in the Symfony tutorial were replaced with a react component loading the code right from GH. Syntax highlighting for twig files does not work as of now (waiting for PrismJS/prism#3730 to be merged).

@Ashutosh-Bhadauriya
Copy link
Contributor

Thanks a lot, Alex 🙌

@Ashutosh-Bhadauriya Ashutosh-Bhadauriya merged commit b172fb8 into teamhanko:main Sep 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants