-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slan to ImodModel attribute and IMAT to ImodModel.object attribute + testing & documentation #20
Conversation
2. Added an example file with multiple objects 3. Added testing for the file with multiple objects.
Made slans a model attribute and imat an object attribute. Added new test example file and tests to the model_api. Added documentation on using ImodModel.
Wonderful - while we're at it, do you think the attribute should be .slan or .slicer_angles? I'm fine with either but prefer the aesthetics of slicer_angles - if we go with slicer_angles can we update the selector for annotation type where it's 'slan' too? Great work as always @braxtonowens ! |
Looks like you have some merge conflicts, you'll have to rebase on main |
Yeah, I like slicer_angles better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Minor consistency/style things - merging as soon as tests pass, thanks @braxtonowens !
@braxtonowens I've given you maintenance powers on the repo - let's still discuss things over PRs with the other but you're doing a great job and should have the ability to move the project forward 🙂 Would you like to trigger the deployment workflow with this new code so that it's available on PyPI? The deployment workflow is stored here: imodmodel/.github/workflows/test_and_deploy.yml Lines 1 to 76 in 5908efc
If you take a look at that workflow you'll see it is trigger when a 'tagged commit' matching 'v*' is pushed to the main branch. one time things
deployment workflow
Once you do this, you should see things launch in the actions tab of the repository If you don't want to do this let me know and I'm happy to do it too - only written up in case you would like to learn |
Great, I think everything went smooth for v0.0.13. Thanks for the help. |
Great!! |
I incorrectly made Slicer angles an
ImodModel.object
attribute in Parse SLAN Chunks #17. It is now anImodModel
attribute.IMAT is now an
ImodModel.object
attribute instead of anImodModel
attribute.Added mod file with multiple objects along with testing.
Added documentation for using
ImodModel
.