-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finetune function #68
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 40 48 +8
Lines 1411 1727 +316
======================================
- Misses 1411 1727 +316 ☔ View full report in Codecov by Sentry. |
|
||
|
||
@cli.command(name="finetune", no_args_is_help=True) | ||
def finetune( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Can we have a finetune and finetune_advanced similar to training options, though?
I think it would be nice to not have the overwhelming choice of parameters for standard users, but instead have most standard parameters set by default.
verbose=True, # Print a message when a checkpoint is saved | ||
) | ||
|
||
class ToleranceCallback(Callback): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put this class into a separate file? Does it fit to optim_utils?
# Monitor learning rate changes | ||
lr_monitor = LearningRateMonitor(logging_interval="epoch", log_momentum=True) | ||
|
||
class PrintLearningRate(Callback): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also put this into another file?
No description provided.