Update backup file (#58)

* unlink backup path if exists * update gitignore * remove unnecessary star files --------- Co-authored-by: Hanjin Liu <[email protected]>
teamtomo · Apr 29, 2024 · 0606cf4 · 0606cf4
1 parent 4f99ec6
commit 0606cf4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -15,3 +15,6 @@
 /m2relion/
 package.sh
 MANIFEST
+
+__pycache__/
+/tests/data/*.star~
diff --git a/src/starfile/writer.py b/src/starfile/writer.py
@@ -92,6 +92,8 @@ def backup_if_file_exists(self):
         if self.filename.exists():
             new_name = self.filename.name + '~'
             backup_path = self.filename.resolve().parent / new_name
+            if backup_path.exists():
+                backup_path.unlink()
             self.filename.rename(backup_path)
 
 

diff --git a/tests/test_functional_interface.py b/tests/test_functional_interface.py
@@ -37,6 +37,8 @@ def test_write_overwrites_with_backup():
     starfile.write(test_df, output_file)
     backup = test_data_directory / 'test_overwrite_backup.star~'
     assert backup.exists()
+    starfile.write(test_df, output_file)
+    assert backup.exists()
 
 
 def test_read_non_existent_file():