Introduce test for interface fragment on object type #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If interface A is implemented by object B then a fragment F on A should be spreadable on a field returning object B. This is described in the spec under [section 5.5.2.3.1](https://spec.graphql.org/June2018/#sec-Abstract-Spreads-in-Object-Scope).
|
Thanks! I think I made it too type-safe so this case raises an error. I'll look into how this can be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If interface A is implemented by object B then a fragment F on A should be
spreadable on a field returning object B. This is described in the spec
under section
5.5.2.3.1.
This test shows that this fails if a field from the fragment is also selected
in the top level selection. This is a valid use-case when a component lower
in the tree requires the data and the component making the query does too.