Added new function - Override OS type #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To override, add Tag HyclopsOS_override to the target EC2 instance and use either windows or linux (lcase) Signed-off-by: Gabriel Brussa <[email protected]>
Removing debugging lines
| @@ -233,7 +233,11 @@ def get_assigned_template_ids(self, host): | |||
| def adjust_string_length(self, base_string, suffix, max_length): | |||
| if len(suffix) == 0: | |||
| if len(base_string) > max_length: | |||
| return base_string[0:max_length - len("..")] + ".." | |||
| #Strip characters in the middle of the string | |||
| #Get the desired length of each piece based on the max_length, and the chars we're adding | |||
There was a problem hiding this comment.
I found out that when the names are too long, this stripping originally was removing the AWS ID for the name, therefore some names ended up being the same (Ie, auto scaling machines) and causing hyclops to fail and halt.
Changing the way the names are stripped (in the middle instead of the ending) when there is no suffix added fixes the problem.
added 2 commits
June 4, 2015 17:38
Reverse the order of the NICs so Local is the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To override, add Tag HyclopsOS_override to the target EC2 instance and use either windows or linux (lcase)
This was due to some Windows machines tagged as 'Platform':None from AWS, hyclops will add them to the linux templates instead.
Signed-off-by: Gabriel Brussa [email protected]