Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TA-1365): update navbar-brand positioning #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

klaudija-lawrence
Copy link

@klaudija-lawrence klaudija-lawrence commented Oct 17, 2024

Problem

https://techfromsage.atlassian.net/browse/TA-1365

Otis needs to have new branding applied. Whilst implementing this we have noticed that the navbar logo hover/focus styles need improvement.

Example

Before:
image

After (focus):
image

After (hover):
image

Change/Fix

  • Updated positioning of navbar logo to improve focus styles
  • Removed outline on hover

Checklist

TomBirbeckTFS and others added 3 commits October 16, 2024 09:06
* style(TA-1364): update the bootstrap 5 theme

* fix: updated error njk page to get stylesheet from custom css, altered config to allow for PO review

* fix: made logo slightly larger

* fix: fixed issue with active tab

* fix: added back main branch to config

* fix: altered config to allow for po review

* fix: added main filter back to config
@klaudija-lawrence klaudija-lawrence added the 90% 90% PR label Oct 17, 2024
@klaudija-lawrence klaudija-lawrence self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
90% 90% PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants