fix: replacing nav tab underlines with a border instead of a background gradient #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd image gradient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of the work on https://techfromsage.atlassian.net/browse/TA-1919
it's not possible to change the colour of the tab underlines with a separate css rule due to how it's implemented as a background gradient image. The tabs I'm referring to are these:
specifically the thick (4px) underline on the selected tab.
Change/Fix
This PR replaces it with a 4px border. They look identical to me, I've tested the update in Otis so I can see it still behaves correctly with working tabs (the tabs in the kitchen sink demo are not functional).
Checklist