feat(ta-1105): add bundling options to authenticated api #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dean-talis
requested review from
omarqureshi,
malcyL,
haakym,
kiyanwang,
mrliptontea,
stephenrob,
Crevitus and
mikerudd
mrliptontea
approved these changes
Jul 18, 2024
mikerudd
reviewed
Jul 18, 2024
| @@ -11,4 +11,5 @@ export interface AuthenticatedApiFunctionProps { | |||
| vpcSubnets?: ec2.SubnetSelection; | |||
| securityGroups?: Array<ec2.ISecurityGroup>; | |||
| memorySize?: number; | |||
| bundling?: BundlingOptions; | |||
There was a problem hiding this comment.
Is this type correct? I've just had a quick look at the docs and was expecting to see something related to externalModules & nodeModules.
There was a problem hiding this comment.
comment: Good catch. I had imported the wrong thing.
mikerudd
approved these changes
Jul 18, 2024
mike-dean-talis
deleted the
ta-1105-add-bundling-options-to-authenticated-api-function
branch
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst working on the new bookmarking extension API, we need to include
jsdomin a lambda function.jsdomdoes not bundle correctly and requires extra options to help this along. Currently theAuthenticatedApiFunctiondoes not expose the CDK bundling options.Change
AuthenticatedApiFunction