chore: lock node version in circleci #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrliptontea
reviewed
Jan 29, 2024
Comment on lines
23
to
27
| node_setup: | ||
| steps: | ||
| - node/install: | ||
| node-version: "" # use .nvmrc | ||
| - node/install | ||
| - node/install-packages: | ||
| include-branch-in-cache-key: false |
There was a problem hiding this comment.
Actually it looks like we can remove node_setup completely.
There was a problem hiding this comment.
It's still referenced by the end to end tests and commitlint steps
There was a problem hiding this comment.
Oh, ok, didn't see it in the diff so assumed it was only needed by printnodeversion.
mrliptontea
approved these changes
Jan 29, 2024
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locks down the node version in CircleCI to
18.17.1this was defaulting to20.11.0