-
Notifications
You must be signed in to change notification settings - Fork 10
CHI-3523: Aselo Webchat React App POC #3726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
git-subtree-dir: aselo-webchat-react-app git-subtree-split: 3bdd6cb631647a91f479039fe0166d9b2fbc74c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard for me to distinguish what is the original React app that we are basing off and what is the custom code being added, so I don't think I can make useful comments on this one
| let envFileContent = getInitialEnvFile() | ||
| .replace(/(?<=ACCOUNT_SID=)(\w*)/gm, accountSid) | ||
| .replace(/(?<=AUTH_TOKEN=)(\w*)/gm, authToken) | ||
| .replace(/(?<=API_KEY=)(\w*)/gm, apiKey) | ||
| .replace(/(?<=API_SECRET=)(\w*)/gm, apiSecret) | ||
| .replace(/(?<=REACT_APP_DEPLOYMENT_KEY=)(\w*)/gm, deploymentKey) | ||
| .replace(/(?<=REACT_APP_REGION=)(\w*)/gm, region) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are this supposed to go with the client code? Or how are they served?
| }; | ||
|
|
||
| const response = await fetch( | ||
| `https://hrm-development.tl.techmatters.org/lambda/twilio/account-scoped/ACd8a2e89748318adf6ddff7df6948deaf/endChat`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this should be an env var filled in at deploy time?
Description
This POC ports the front end only into the flex plugin repo, and it can only be run locally, but works end to end on Aselo Dev
A follow on PR #3724 shows the next step where we migrate some back end functions as well, which will probably be required to support calling custom stuff from the client
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P