Change command override to be an array item per parameter

techmatters · Jan 7, 2025 · b29193a · b29193a
1 parent d52a241
commit b29193a
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/.github/workflows/generate-ai-training-ecs.yml b/.github/workflows/generate-ai-training-ecs.yml
@@ -54,7 +54,6 @@ jobs:
           SUBNETS=$(if [ ${{ inputs.environment }} == "development" ]; then echo "subnet-034e5c652dbad09dd"; else echo "subnet-00b4e88c0ea178f3d"; fi)
           SECURITY_GROUPS=($(if [ ${{ inputs.environment}} == "development" ]; then echo "sg-09194f9a648baf082 sg-047498d4c7b2cedd8 sg-06d6458accc0ec5ed sg-0ace4338c75e5d3de"; 
             else echo "sg-02fd053fe7b4660ed sg-0e7119c4423f2c7b0 sg-066d0055caa7cbe90 sg-0c7fb74e11cb64ff8"; fi))
-          COMMAND="npm run start:generate-ai-training-set ${{ inputs.environment }} ${{ inputs.helpline-shortcodes }} tl-aselo-ai-${{ inputs.environment }}-us-east-1 tl-aselo-ai-${{ inputs.environment }}-us-east-1"
           TASK_ROLE="arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/${{ inputs.environment }}-ecsTaskRole"
           EXEC_ROLE="arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/${{ inputs.environment }}-ecsTaskExecutionRole"
 
@@ -66,7 +65,17 @@ jobs:
             --overrides '{
               "containerOverrides": [{
                 "name": "'"$FAMILY"'",
-                "command": ["sh", "-c", "'"$COMMAND"'"],
+                "command": [
+                  "sh",
+                  "-c",
+                  "npm",
+                  "run",
+                  "start:generate-ai-training-set",
+                  "${{ inputs.environment }}",
+                  "${{ inputs.helpline-shortcodes }}",
+                  "tl-aselo-ai-${{ inputs.environment }}-us-east-1",
+                  "tl-aselo-ai-${{ inputs.environment }}-us-east-1"
+                ],
                 "environment": [
                   {"name": "SSM_REGION", "value": "us-east-1"},
                   {"name": "AWS_REGION", "value": "us-east-1"}