Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slack action v2.0.0 parameters update #795

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

GPaoloni
Copy link
Collaborator

Description

Latest update of slack message action broke our deploy actions. This PR fixes the expected parameters.

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@GPaoloni GPaoloni merged commit 283c89d into v1.22-rc Dec 16, 2024
14 checks passed
@GPaoloni GPaoloni deleted the gian_fix-slack-action branch December 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants