Merge pull request #11 from technologiestiftung/feat/system-prompt-vi…

…a-frontend feat: system prompt via frontend
technologiestiftung · Aug 22, 2024 · b2ad76b · b2ad76b
2 parents f8d37dd + fd73ca8
commit b2ad76b
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 19 deletions.
diff --git a/src/controllers/chat-controller.ts b/src/controllers/chat-controller.ts
@@ -9,6 +9,7 @@ import {
   ChatRequest,
   ChatResponse,
 } from "../types/chat-types";
+import { resolveMessagesForSystemPrompt } from "../fixtures/system-prompt";
 
 export const chatWithLLM = async (
   req: Request<{}, {}, ChatRequest>,
@@ -19,7 +20,10 @@ export const chatWithLLM = async (
     const { messages } = req.body;
     const llmHandler = resolveLlmHandler(llm);
 
-    const llmRespone = await llmHandler.chatCompletion(messages);
+    const resolvedMessages = resolveMessagesForSystemPrompt(messages);
+
+    const llmRespone = await llmHandler.chatCompletion(resolvedMessages);
+
     if (llmRespone.stream) {
       await pipeline(llmRespone.stream, res);
       return;

diff --git a/src/fixtures/system-prompt.ts b/src/fixtures/system-prompt.ts
@@ -1,4 +1,23 @@
-export const SYSTEM_PROMPT = `
+import { ChatMessage } from "../types/chat-types";
+
+export const resolveMessagesForSystemPrompt = (
+  messages: ChatMessage[]
+): ChatMessage[] => {
+  const systemPromptMessages = messages.filter(
+    (message) => message.role === "system"
+  );
+
+  // If there are no system prompt messages, add the default system prompt message
+  if (systemPromptMessages.length === 0) {
+    return [{ role: "system", content: DEFAULT_SYSTEM_PROMPT }].concat(
+      messages
+    ) as ChatMessage[];
+  }
+
+  return messages;
+};
+
+const DEFAULT_SYSTEM_PROMPT = `
 Sie sind BärGPT, ein virtueller Assistent für die öffentliche Verwaltung in Berlin. Ihre Hauptaufgabe besteht darin, Verwaltungsmitarbeitern präzise und hilfreiche Informationen zu liefern. Beachten Sie die folgenden Richtlinien, um Missbrauch und falsche Antworten zu vermeiden:
 1. **Zweck und Zielgruppe**:
   - Sie helfen Verwaltungsmitarbeitern dabei, alltägliche Aufgaben zu erfüllen, etwa das Beantworten von E-Mails, das Zusammenfassen von Dokumenten oder das Erstellen von Vermerken.

diff --git a/src/llm-handlers/azure-llm-handler.ts b/src/llm-handlers/azure-llm-handler.ts
@@ -1,5 +1,4 @@
 import { config } from "..";
-import { SYSTEM_PROMPT } from "../fixtures/system-prompt";
 import { ChatMessage } from "../types/chat-types";
 import { LLMHandler, LLMResponse } from "../types/llm-handler-types";
 import { convertWebStreamToNodeStream } from "../utils/stream-utils";
@@ -18,18 +17,14 @@ export class AzureLLMHandler implements LLMHandler {
   async chatCompletion(messages: ChatMessage[]): Promise<LLMResponse> {
     let endpoint = `${this.endpoint}&api-key=${config.azureLlmApiKey}`;
 
-    const messagesWithSystemPromps = [
-      { role: "system", content: SYSTEM_PROMPT },
-    ].concat(messages);
-
     try {
       const response = await fetch(endpoint, {
         method: "POST",
         headers: {
           "Content-Type": "application/json",
         },
         body: JSON.stringify({
-          messages: messagesWithSystemPromps,
+          messages: messages,
           temperature: LLM_PARAMETERS.temperature,
           stream: LLM_PARAMETERS.stream,
         }),

diff --git a/src/llm-handlers/ollama-llm-handler.ts b/src/llm-handlers/ollama-llm-handler.ts
@@ -1,5 +1,4 @@
 import { config } from "..";
-import { SYSTEM_PROMPT } from "../fixtures/system-prompt";
 import { ChatMessage } from "../types/chat-types";
 import { LLMHandler, LLMResponse } from "../types/llm-handler-types";
 import { convertWebStreamToNodeStream } from "../utils/stream-utils";
@@ -16,10 +15,6 @@ export class OllamaLlmHandler implements LLMHandler {
   }
 
   async chatCompletion(messages: ChatMessage[]): Promise<LLMResponse> {
-    const messagesWithSystemPromps = [
-      { role: "system", content: SYSTEM_PROMPT },
-    ].concat(messages);
-
     try {
       const response = await fetch(this.endpoint, {
         method: "POST",
@@ -28,7 +23,7 @@ export class OllamaLlmHandler implements LLMHandler {
         },
         body: JSON.stringify({
           model: this.model,
-          messages: messagesWithSystemPromps,
+          messages: messages,
           options: { temperature: LLM_PARAMETERS.temperature },
           stream: LLM_PARAMETERS.stream,
         }),

diff --git a/src/llm-handlers/openai-handler.ts b/src/llm-handlers/openai-handler.ts
@@ -1,5 +1,4 @@
 import { config } from "..";
-import { SYSTEM_PROMPT } from "../fixtures/system-prompt";
 import { ChatMessage } from "../types/chat-types";
 import { LLMHandler, LLMResponse } from "../types/llm-handler-types";
 import { convertWebStreamToNodeStream } from "../utils/stream-utils";
@@ -16,9 +15,6 @@ export class OpenAILLMHandler implements LLMHandler {
   }
 
   async chatCompletion(messages: ChatMessage[]): Promise<LLMResponse> {
-    const messagesWithSystemPromps = [
-      { role: "system", content: SYSTEM_PROMPT },
-    ].concat(messages);
     try {
       // Check if the message contains inappropriate content by using the /moderations endpoint
       const moderationsResponse = await fetch(`${this.endpoint}/moderations`, {
@@ -56,7 +52,7 @@ export class OpenAILLMHandler implements LLMHandler {
         },
         body: JSON.stringify({
           model: this.model,
-          messages: messagesWithSystemPromps,
+          messages: messages,
           temperature: LLM_PARAMETERS.temperature,
           stream: LLM_PARAMETERS.stream,
         }),