Skip to content

Conversation

raphael-arce
Copy link
Contributor

@raphael-arce raphael-arce commented Oct 1, 2024

  • disable renovate by default <- not anymore, we've decided to enable/disable renovate via the renovate github app,
  • remove vscode settings folder,
  • add .idea folder to gitignore,
  • updated readme
  • updated default workflow

… .idea folder to gitignore, update readme and default workflow

Signed-off-by: Raphael Arce <[email protected]>
@ff6347
Copy link
Collaborator

ff6347 commented Oct 2, 2024

I am not a fan of this decision, since the opt in is harder for users then the opt out. But, hey, not my business anymore 😏. But shouldn't the README tell, in the section about renovate, that it needs to be enabled if desired? @raphael-arce

@ff6347
Copy link
Collaborator

ff6347 commented Oct 2, 2024

@raphael-arce
Copy link
Contributor Author

@ff6347 Yes, there is this line in the readme: https://github.com/technologiestiftung/template-repo-citylab/pull/19/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R18
or do you mean something else?

As most of the devs in the TSB complain about renovate and are not necessarily familiar with it (e.g. know how to disable it), I think it's more pragmatic to disable by default, but when needed/enabled, use the same rules as before.

@ff6347
Copy link
Collaborator

ff6347 commented Oct 2, 2024

Ah . Sorry did not see it. But this template is CityLAB specific. If you want to disable it globally you should go for the shared renovate config.

@raphael-arce
Copy link
Contributor Author

I know what you mean, but I don't intend to disable Renovate globally. The goal is for future projects created from this template to have the flexibility to enable it when needed, by simply setting "enabled": true in the .github/renovate.json file 👍

Copy link
Contributor

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ff6347
Copy link
Collaborator

ff6347 commented Oct 2, 2024

But then renovate will be active on repos that don't use this template

docs: update readme

Signed-off-by: Raphael Arce <[email protected]>
@raphael-arce
Copy link
Contributor Author

@ff6347 that's a fair point. We've discussed it a bit with the team and the opinions were that it'd be easier/better to handle enabling/disabling renovate by selecting repositories manually in the renovate github app. I've removed the relevant line in the renovate.json 👍

@ff6347
Copy link
Collaborator

ff6347 commented Oct 9, 2024

@raphael-arce this sounds a little like moving away from renovate. The can everybody change the settings of the GitHub App? Will anyone think of renovate when it is not active by default? I know the little bot can be annoying at times but better then dependencies rotting away. 😄

@raphael-arce
Copy link
Contributor Author

@ff6347 No, we’re not looking to move away from renovate, just more actively choose when it's enabled. It’s not set in stone, we want to try this approach and adjust based on how well it works.

@raphael-arce raphael-arce merged commit bf3f6a2 into main Oct 11, 2024
1 check passed
@raphael-arce raphael-arce deleted the feat/update branch October 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants