Skip to content

Refactoring 1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kon-Xen wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Refactoring 1 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ea7bf3a
added some empty tests
tomscambler Aug 18, 2022
c77cdbd
quality decreases and increases
tomscambler Aug 18, 2022
9a00bff
Merge pull request #1 from Kon-Xen/test-1
tomscambler Aug 18, 2022
a7d90ec
Tests part 2 all passing !
Kon-Xen Aug 18, 2022
d147e40
Merge pull request #2 from Kon-Xen/test-2
Kon-Xen Aug 18, 2022
a062849
tests complete
tomscambler Aug 18, 2022
ffb5d03
Merge pull request #3 from Kon-Xen/test-3
Kon-Xen Aug 18, 2022
d320499
first "if"
Kon-Xen Aug 18, 2022
989a6ce
smaller variables
Kon-Xen Aug 18, 2022
3ea780d
smaller variables for quality and name
Kon-Xen Aug 18, 2022
5fbfc59
smaller variables for quality and name and sellin
Kon-Xen Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions app/gilded-rose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,51 +17,56 @@ export class GildedRose {
this.items = items;
}


updateQuality() {
for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}

let itemName = this.items[i].name;
let itemQuality = this.items[i].quality;
let itemSell_in = this.items[i].sellIn;

if (itemName != 'Aged Brie' && itemName != 'Backstage passes to a TAFKAL80ETC concert' && itemName != 'Sulfuras, Hand of Ragnaros') {
itemQuality = itemQuality == 0? 0: itemQuality-1 ;

} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (itemQuality < 50) {
itemQuality += 1
if (itemName == 'Backstage passes to a TAFKAL80ETC concert') {
if (itemSell_in< 11) {
if (itemQuality < 50) {
itemQuality += 1;
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (itemSell_in< 6) {
if (itemQuality < 50) {
itemQuality += 1 ;
}
}
}
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;
if (itemName != 'Sulfuras, Hand of Ragnaros') {
itemSell_in -= 1;
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
if (itemSell_in < 0) {
if (itemName != 'Aged Brie') {
if (itemName != 'Backstage passes to a TAFKAL80ETC concert') {
if (itemQuality> 0) {
if (itemName != 'Sulfuras, Hand of Ragnaros') {
itemQuality -= 1;
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
itemQuality = 0;
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (itemQuality < 50) {
itemQuality += 1
}
}
}
this.items[i].quality = itemQuality;
this.items[i].sellIn = itemSell_in;
}

return this.items;
Expand Down
Loading