fix: include instance name in Login7 message and traceID in prelogin
#1668
+45
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPVallancourt
changed the title
|
Hi @arthurschreiber , are there any other things I need to do get this incorporated into the library? |
arthurschreiber
changed the title
Login7 message
|
@TPVallancourt This seems to break the appveyor build on Windows 🤔 |
src/connection.ts
Outdated
| @@ -2484,7 +2485,7 @@ class Connection extends EventEmitter { | |||
| } | |||
|
|
|||
| payload.hostname = this.config.options.workstationId || os.hostname(); | |||
| payload.serverName = this.routingData ? this.routingData.server : this.config.server; | |||
| payload.serverName = this.routingData ? `${this.routingData.server}\\${this.routingData.instance}` : this.config.server; | |||
There was a problem hiding this comment.
Is instance here guaranteed to always be a non-empty string? What happens if it's empty?
TPVallancourt
changed the title
Login7 messageLogin7 message and traceID in prelogin
|
@TPVallancourt Hi, just curious if this is planned to be merged and released soon? I am currently relying on this PR for Fabric Warehouse connections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1563
instance. Previously we just savedserverwhich removes the instance name from the redirect URL. This is the proper string for TLS negotiation, but Login7 needs theserverand theinstancetogether.preloginpayload, include a randomly generated traceID, Starting with TDS37.0 it seems that traceID is no longer optional for Fabric.