Skip to content

[Security] Bump devise from 4.2.1 to 4.6.0#94

Closed
dependabot-preview[bot] wants to merge 1 commit intomasterfrom
dependabot/bundler/devise-4.6.0
Closed

[Security] Bump devise from 4.2.1 to 4.6.0#94
dependabot-preview[bot] wants to merge 1 commit intomasterfrom
dependabot/bundler/devise-4.6.0

Conversation

@dependabot-preview
Copy link

Bumps devise from 4.2.1 to 4.6.0. This update includes a security fix.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Devise Gem for Ruby Time-of-check Time-of-use race condition with lockable module
Devise ruby gem before 4.6.0 when the lockable module is used is vulnerable to a
time-of-check time-of-use (TOCTOU) race condition due to increment_failed_attempts
within the Devise::Models::Lockable class not being concurrency safe.

Patched versions: >= 4.6.0
Unaffected versions: none

Changelog

Sourced from devise's changelog.

4.6.0 - 2019-02-07

  • enhancements

    • Allow to skip email and password change notifications (by @​iorme1)
    • Include the use of nil for allow_unconfirmed_access_for in the docs (by @​joaumg)
    • Ignore useless files into the .gem file (by @​huacnlee)
    • Explain the code that prevents enumeration attacks inside Devise::Strategies::DatabaseAuthenticatable (by @​tegon)
    • Refactor the devise_error_messages! helper to render a partial (by @​prograhamer)
    • Add an option (Devise.sign_in_after_change_password) to not automatically sign in a user after changing a password (by @​knjko)
  • bug fixes

    • Fix missing comma in Simple Form generator (by @​colinross)
    • Fix error with migration generator in Rails 6 (by @​oystersauce8)
    • Set encrypted_password to nil when password is set to nil (by @​sivagollapalli)
    • Consider whether the request supports flash messages inside Devise::Controllers::Helpers#is_flashing_format? (by @​colinross)
    • Fix typo inside Devise::Generators::ControllersGenerator (by @​kopylovvlad)
    • Sanitize parameters inside Devise::Models::Authenticatable#find_or_initialize_with_errors (by @​rlue)
    • #after_database_authentication callback was not called after authentication on password reset (by @​kanmaniselvan)
    • Fix corner case when #confirmation_period_valid? was called at the same second as confirmation_sent_at was set. Mostly true for date types that only have second precisions. (by @​stanhu)
    • Fix unclosed li tag in error_messages partial (by @​mracos)
    • Fix Routes issue when devise engine is mounted in another engine on Rails versions lower than 5.1 (by @​a-barbieri)
    • Make #increment_failed_attempts concurrency safe (by @​tegon)
    • Apply Test Helper fix to Rails 6.0 as well as 5.x (by @​matthewrudy)
  • deprecations

    • The second argument of DatabaseAuthenticatable's #update_with_password and #update_without_password is deprecated and will be removed in the next major version. It was added to support a feature deprecated in Rails 4, so you can safely remove it from your code. (by @​ihatov08)
    • The DeviseHelper.devise_error_messages! is deprecated and will be removed in the next major version. Use the devise/shared/error_messages partial instead. (by @​mracos)

4.5.0 - 2018-08-15

  • enhancements

    • Use before_action instead of before_filter (by @​edenthecat)
    • Allow people to extend devise failure app, through invoking ActiveSupport.run_load_hooks once Devise::FailureApp is loaded (by @​wnm)
    • Use update instead of update_attributes (by @​koic)
    • Split IP resolution from update_tracked_fields (by @​mckramer)
    • upgrade dependencies for rails and responders (by @​lancecarlson)
    • Add autocomplete="new-password" to new password fields (by @​gssbzn)
    • Add autocomplete="current-password" to current password fields (by @​gssbzn)
    • Remove redundant self from database_authenticatable module (by @​abhishekkanojia)
    • Update simple_form templates with changes from heartcombo/devise@16b3d6d and heartcombo/devise@6260c29 (by @​gssbzn)
    • Remove :trackable from the default modules in the generators, to be more GDPR-friendly (by @​fakenine)
  • bug fixes

    • Use same string on failed login regardless of whether account exists when in paranoid mode (by @​TonyMK9068)
    • Fix error when params is not a hash inside Devise::ParameterSanitizer (by @​b0nn1e)
    • Look for secret_key_base inside Rails.application (by @​gencer)
    • Ensure Devise::ParameterFilter does not add missing keys when called with a hash that has a default / default_proc
      configured (by @​joshpencheon)
    • Adds is_navigational_format? check to after_sign_up_path_for to keep consistency (by @​iorme1)
... (truncated)
Commits
  • 4501682 Prepare for 4.6.0 release
  • 337db5a Update CHANGELOG.md [ci skip]
  • a921c10 Merge pull request #5018 from plataformatec/frg-fix-webrat-warning
  • 101e50f Fix webrat warnings
  • 6064ca8 Merge pull request #5014 from plataformatec/frg-fix-test-setup
  • 2dd3225 Fix bin/test to use Rails::TestUnit
  • e72839f Merge pull request #5011 from plataformatec/frg-fix-sqlite-warning
  • 45438fc Fix SQLite3 warning
  • f332911 Update README to help run tests [ci skip] (#5012)
  • 369ba26 removing white space in devise generator new.html.erb (#5010)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [devise](https://github.com/plataformatec/devise) from 4.2.1 to 4.6.0. **This update includes a security fix.**
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
- [Commits](heartcombo/devise@v4.2.1...v4.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Aug 20, 2019
@dependabot-preview
Copy link
Author

Superseded by #98.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/devise-4.6.0 branch September 10, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant