Skip to content

⚡ Bolt: Avoid libm::sqrt in ManifoldPoint::is_neighbor#126

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt/opt-is-neighbor-sqrt-6886637532171051806
Open

⚡ Bolt: Avoid libm::sqrt in ManifoldPoint::is_neighbor#126
teerthsharma wants to merge 1 commit into
masterfrom
bolt/opt-is-neighbor-sqrt-6886637532171051806

Conversation

@teerthsharma

Copy link
Copy Markdown
Owner

💡 What: Replaced the libm::sqrt-based exact distance calculation with an inline squared distance loop in ManifoldPoint::is_neighbor. Implemented early exit when the squared distance sum exceeds the squared epsilon (eps_sq) and added robust handling for NaN/negative inputs using ! logic.

🎯 Why: SparseAttentionGraph::add_point calls is_neighbor inside an $O(N)$ loop for every point added, making it a critical hot path for spatial graph construction. The sqrt operation is expensive and unnecessary for simple threshold comparisons.

📊 Impact: Significantly speeds up the sparse attention mechanism by completely avoiding square root operations and short-circuiting dimension evaluation when points are provably outside the radius.

🔬 Measurement: Run cargo test -p aether-core manifold to ensure correctness. The performance gain can be seen in microbenchmarks or any workloads generating continuous spatial structures.


PR created automatically by Jules for task 6886637532171051806 started by @teerthsharma

Optimizes the `is_neighbor` check used in `SparseAttentionGraph::add_point`
by comparing squared distances instead of calling the expensive `libm::sqrt`.
Includes early exit capabilities and correctly handles NaN/negative thresholds
and coordinates.

Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant