Skip to content

Commit

Permalink
commitlint: temporarily disable footernotes rule
Browse files Browse the repository at this point in the history
Upon discovering this bug:
nblockchain#118
  • Loading branch information
knocte committed Jul 6, 2023
1 parent 51b1176 commit 8b38178
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion commitlint.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ module.exports = {
"always",
footerMaxLineLength,
],
"footer-notes-misplacement": [RuleConfigSeverity.Error, "always"],
// temporarily disabled because of https://github.com/nblockchain/conventions/issues/118
"footer-notes-misplacement": [RuleConfigSeverity.Disabled, "always"],
"footer-refs-validity": [RuleConfigSeverity.Error, "always"],
"header-max-length-with-suggestions": [
RuleConfigSeverity.Error,
Expand Down
2 changes: 2 additions & 0 deletions commitlint/plugins.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ test("empty-wip-3", () => {
expect(emptyWIP3.status).toBe(0);
});

/* temporarily disabled rule because of https://github.com/nblockchain/conventions/issues/118
test("footer-notes-misplacement-1", () => {
let commitMsgWithRightFooter =
"foo: this is only a title" +
Expand Down Expand Up @@ -508,6 +509,7 @@ test("footer-notes-misplacement-4", () => {
let footerNotesMisplacement4 = runCommitLintOnMsg(commitMsgWithWrongFooter);
expect(footerNotesMisplacement4.status).not.toBe(0);
});
*/

test("footer-refs-validity1", () => {
let commmitMsgWithCorrectFooter =
Expand Down

0 comments on commit 8b38178

Please sign in to comment.