Skip to content

Commit

Permalink
fix nil pointer
Browse files Browse the repository at this point in the history
  • Loading branch information
jkhelil committed Nov 7, 2024
1 parent 227b311 commit 07b73ab
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,15 @@ func buildConfig(ctx context.Context, pro *objects.PipelineRunObjectV1Beta1) Bui
}

steps := []attest.StepAttestation{}
if tr.Status.TaskSpec == nil || tr.Status.Steps == nil {
logger.Errorf("Nil TaskSpec or Steps in task run %s", tr.Name)
continue // Skip this task run if any part is nil
}
// tr.Status.TaskSpec.Steps and tr.Status.Steps should be sime size
if tr.Status.TaskSpec == nil || len(tr.Status.TaskSpec.Steps) != len(tr.Status.Steps) {
if len(tr.Status.TaskSpec.Steps) != len(tr.Status.Steps) {
logger.Errorf("Mismatch in number of steps for task run %s. TaskSpec steps: %d, Status steps: %d",
tr.Name, len(tr.Status.TaskSpec.Steps), len(tr.Status.Steps))
continue // Skip this task run entirely
continue
}

// Validate and process steps
Expand Down

0 comments on commit 07b73ab

Please sign in to comment.