-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nil pointer dereference when taksrun is canceled #1237
fix nil pointer dereference when taksrun is canceled #1237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-v0.22.x |
/cherry-pick release-v0.21.x |
/cherry-pick release-v0.22.x |
@vdemeester: new pull request created: #1246 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v0.21.x |
@vdemeester: #1237 failed to apply on top of branch "release-v0.21.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
When taskrun is status TaskRunCancelled, there is no Status.TaskSpec., the PR aims to fix the test so we dont fall in the nil pointer dereference
here is a status of canceled taskrun
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes