Skip to content

Resolved the different log output issue for tkn p logs and tkn pr logs. #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resolved the different log output issue for tkn p logs and tkn pr logs. #2235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b3352
Resolved the logs issue, unit tests pending
Senjuti256 Feb 1, 2024
646caca
New Dynamic client created
Senjuti256 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/cmd/tkn_pipeline_logs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Show logs for given Pipeline and PipelineRun:
-h, --help help for logs
-L, --last show logs for last PipelineRun
--limit int lists number of PipelineRuns (default 5)
--prefix prefix each log line with the log source (task name and step name) (default true)
-t, --timestamps show logs with timestamp
```

Expand Down
4 changes: 4 additions & 0 deletions docs/man/man1/tkn-pipeline-logs.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ Show Pipeline logs
\fB\-\-limit\fP=5
lists number of PipelineRuns

.PP
\fB\-\-prefix\fP[=true]
prefix each log line with the log source (task name and step name)

.PP
\fB\-t\fP, \fB\-\-timestamps\fP[=false]
show logs with timestamp
Expand Down
Binary file added pipeline
View file
Open in desktop
Binary file not shown.
6 changes: 5 additions & 1 deletion pkg/cmd/pipeline/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Show logs for given Pipeline and PipelineRun:
c.Flags().BoolVarP(&opts.Follow, "follow", "f", false, "stream live logs")
c.Flags().BoolVarP(&opts.Timestamps, "timestamps", "t", false, "show logs with timestamp")
c.Flags().IntVarP(&opts.Limit, "limit", "", 5, "lists number of PipelineRuns")

c.Flags().BoolVarP(&opts.Prefixing, "prefix", "", true, "prefix each log line with the log source (task name and step name)")
return c
}

Expand Down Expand Up @@ -206,3 +206,7 @@ func askRunName(opts *options.LogOptions) error {

return opts.Ask(options.ResourceNamePipelineRun, prs)
}




Loading