Skip to content

Conversation

@divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Jul 18, 2025

Changes

Follow up changes after PR #2559 to include few fixes in the .golangci file as well as update the golangci-lint to use v2 version.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2025
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2025
@divyansh42 divyansh42 closed this Jul 19, 2025
@divyansh42 divyansh42 reopened this Jul 24, 2025
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@divyansh42 divyansh42 force-pushed the pr-2559 branch 2 times, most recently from 83613a5 to dccc19e Compare July 28, 2025 10:42
- Updated golangci-lint to use v2 version
- Fixed regex to ignore the files like third_party in lint
@divyansh42 divyansh42 changed the title [Do not merge] Test commit update golangci-lint to v2 Jul 28, 2025
@divyansh42 divyansh42 changed the title update golangci-lint to v2 Update golangci-lint to v2 Jul 28, 2025
@chmouel
Copy link
Member

chmouel commented Jul 28, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@divyansh42
Copy link
Member Author

/cc @vdemeester @pratap0007

@tekton-robot tekton-robot requested a review from vdemeester July 28, 2025 10:59
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@tekton-robot tekton-robot merged commit cdc5667 into tektoncd:main Jul 28, 2025
14 of 15 checks passed
@divyansh42
Copy link
Member Author

/release-note-none

@tekton-robot
Copy link
Contributor

@divyansh42: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyansh42
Copy link
Member Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants