Skip to content

chore: referencing the setup-kind script from the plumbing repo instead of copying it #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: referencing the setup-kind script from the plumbing repo instead of copying it #2590

wants to merge 1 commit into from

Conversation

infernus01
Copy link

Changes

Fixes #2520

  • Remove hack/setup-kind.sh and replaced by tektoncd/plumbing version

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 14, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chmouel after the PR has been reviewed.
You can assign the PR to them by writing /assign @chmouel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2025
@divyansh42
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 16, 2025
@divyansh42
Copy link
Member

/ok-to-test

@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@pratap0007
Copy link
Contributor

/ok-to-test
/retest

@infernus01
Copy link
Author

Did the CI run? Since we already have /ok-to-test multiple times, but I didn't see the CIs running anytime?

@divyansh42
Copy link
Member

Did the CI run? Since we already have /ok-to-test multiple times, but I didn't see the CIs running anytime?

It seems there is some issue, can you try to rebase the PR?

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@tekton-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@pratap0007 pratap0007 Awaiting requested review from pratap0007

Assignees

@pratap0007 pratap0007

Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider referencing the existing script in the plumbing repo instead of copying it
4 participants
@infernus01 @tekton-robot @divyansh42 @pratap0007