Repository navigation
Conversation
Let kind create the cluster with the node image its release was tested with instead of pinning kindest/node separately, and remove the Renovate rules that tracked that pin. Two independent pins could each be bumped into a pair that does not work. Also drop the Cleanup step from the e2e workflow. GitHub-hosted runners are discarded after the job, so it only added time. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -25,8 +25,8 @@ jobs: | |||
|
|
|||
| - name: Install pinned kind version | |||
There was a problem hiding this comment.
should we change the step name as this is no longer using the pinned image ?
There was a problem hiding this comment.
Good point. The kind binary is still pinned through KIND_VERSION, but the node image now follows that release's default, so the old name was misleading. I renamed the step to "Install pinned kind release (uses its default node image)".
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Changes
I made two changes to
.github/workflows/test-e2e.ymlonmain:Cleanupstep (make undeploy,make uninstall,kubectl delete ns tekton-kueue). The job runs onubuntu-latest, and GitHub-hosted runners are thrown away when the job ends, so the step only added time after the tests. This matches what ci: backport GitHub Actions workflows from main #543 did forrelease-v0.3.x.--image kindest/node:...tokind create cluster, so kind uses the node image its release was tested with, including the digest. I kept theKIND_VERSIONpin and its Renovate marker. I removed the inlinekindest/nodeRenovate marker, plus thekindest/nodecustom manager and the kind/node group rule in.github/renovate.json, since nothing else uses them.Fixes #549
Fixes #551
/kind cleanup
Submitter Checklist
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes