-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] REMOVE NGSIv1 dead code #4603
Open
fgalan
wants to merge
63
commits into
master
Choose a base branch
from
remove/ngsiv1-deadcode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tServices file is now clean
…nd postUpdateContext() functions
… and OrionError::smartRender() functions (unit tests broken at this point)
…of the code (unit tests broken at this point)
…ontextSubscriptionResponse, DiscoverContextAvailabilityResponse, RegisterContextRequest, RegisterContextResponse, tag module, toJsonV1() methods and several check() methods (unit tests still not working)
…r, SubscribeResponse, SubscriptionId, Throttling, SubscribeContextRequest, SubscribeContextResponse, UnsubscribeContextRequest, UnsubscribeContextResponse and DiscoverContextAvailabilityRequest classes and unused items in RequestType enumeration
…strictionString, AttributeExpression and ContextRegistrationVector
This reverts commit 80e1a56.
…t may still fail)
… should work now)
… used instead) and solve several FIXME PR
fgalan
force-pushed
the
remove/ngsiv1-deadcode
branch
from
September 6, 2024 08:56
bc56497
to
45058b6
Compare
fgalan
force-pushed
the
remove/ngsiv1-deadcode
branch
from
September 11, 2024 12:31
0db78bd
to
4125c4d
Compare
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGSIv1 API was gradually removed from Orion 2.6.0 to 4.0.0, but a lot of dead code remains.
This PR removes that dead code.