FIX 3001_mqtt_alarms removing dependency on external MQTT broker#4638
Merged
FIX 3001_mqtt_alarms removing dependency on external MQTT broker#4638
Conversation
fgalan
commented
Jan 13, 2025
| @@ -0,0 +1 @@ | |||
| user1:$7$101$eqgU7wUvh4Y3VQAm$ovEPI43qOwAskK5M+OFmNJAoXtLRx5GI2tBjTX4AOf3ZTB79IRv1CMgbHrPnKY+/K/RKMm2i/XFp9syteeOCvg== | |||
Member
Author
There was a problem hiding this comment.
Nothing dangerous here :) This is just the codification of "xxxx"
6ff9406 to
25ed111
Compare
Member
Author
|
A lot of testing (around 50 commits :) in this PR, so I have rebase and force push to clean it up. |
fgalan
commented
Jan 16, 2025
| mosquitto-extra: | ||
| # Needed by MQTT notification tests (multi broker) | ||
| #image: eclipse-mosquitto:2.0.11 | ||
| image: eclipse-mosquitto:1.6.15 |
Member
Author
There was a problem hiding this comment.
The MQTT broker in 1883 uses 2.0.11 version without problem (see L59), but this auxiliar MQTT broker in 1884 has to be 1.6.15 or 3001_mqtt/mqtt_subscription_multibroker.test will break.
It's weird... I'm looking at it.
Member
Author
|
As a side-improvement, MQTT broker version has been updated from 1.6.7 to 2.0.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema found in PR #4637
Maybe mqtt.flespi.io is no longer available... better not depending on any external MQTT service.
Working locally:
but unsure about GitAction configuration... let's see