-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tooltip-position inside scaleModal #1874
Conversation
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey @niclas18 this is brilliant, thank you. In order to make CI pass, would you be so kind and please do the following:
|
Hi @acstll , thanks for your comment. If the trigger of the tooltip is relatively at the edge of an element and the associated message is very long, then the arrow is no longer over the element. This can also be reproduced in the storybook. This also happens in the modal. By changing the CSS in the PR and changing the CSS of the corresponding scale modal:
it now works reliably. Maybe you could see if it is necessary to use "position: relative" in ScaleModal. If not and you change it globally to "position: static", one wouldn't need the above code. |
Hello, is there any chance to get this merged? Scale tooltips inside modal dialogs have been a problem in our application for a long time. And I would like to wait for this possible fix before deciding to create our own tooltip component. |
hi there thanks a lot for the PR and sorry for the delay, we duplicated this PRs changes here #2206 to fix the CI jobs - we should merge and publish this with the next release. |
closing this as the dupe pr has just been merged, thanks again for this one |
As described in #1742 there is a problem with the position of tooltips inside modals.
The used package @floating-ui/dom have a problem with the shadow-roots there.
They have a fix in there documentation for this type of problems.
I added this and it fixed the problem for us.