Skip to content

List items height #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

List items height #5569

wants to merge 3 commits into from

Conversation

inikolova
Copy link
Contributor

@inikolova inikolova commented Aug 29, 2025 •
edited
Loading

Closes #3818

According to caniuse, the lh unit is widely supported and currently works across all major browsers:
https://caniuse.com/mdn-css_types_length_lh

@inikolova inikolova requested a review from a team as a code owner August 29, 2025 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2025 •
edited
Loading

Packages Report

core default classic bootstrap material fluent utils
Size 29.40 KB (0.0%) 763.21 KB (0.0%🔼) 763.24 KB (0.0%🔼) 776.11 KB (0.0%🔼) 911.35 KB (0.0%🔼) 1176.96 KB (0.0%🔼) 625.19 KB (0.0%)
Gzip Size 4.85 KB (0.0%) 98.74 KB (0.0%🔼) 99.06 KB (0.0%🔼) 100.64 KB (0.0%🔼) 111.70 KB (0.0%🔼) 136.14 KB (0.0%🔼) 52.16 KB (0.0%)
Compile Time 1 s (0.0%) 3 s (0.0%) 4 s (0.0%) 5 s (0.0%) 4 s (0.0%) 5 s (0.0%) 3 s (0.0%)

@inikolova inikolova marked this pull request as draft August 29, 2025 12:40
@inikolova inikolova self-assigned this Aug 29, 2025
@inikolova inikolova added Bug Something isn't working C: List labels Aug 29, 2025
@inikolova inikolova force-pushed the list-items-height branch 3 times, most recently from 32ee725 to 2474aed Compare August 29, 2025 13:57
@inikolova inikolova marked this pull request as ready for review August 29, 2025 14:04
@inikolova inikolova added Enhancement New feature of an existing functionality or an improvement of an existing functionality. and removed Bug Something isn't working labels Aug 29, 2025
@inikolova inikolova requested a review from a team August 29, 2025 14:58
zhpenkov
zhpenkov reviewed Aug 29, 2025
View reviewed changes
@Juveniel
Copy link
Contributor

Juveniel commented Sep 1, 2025

we should check if this works correctly in virtualized scenarios. We have actually tried this fix before, but hit some limitations/scenarios where the lh height failed. Please, review some actual component demos with virtualization/advanced scenarios to verify that this works correctly.

@inikolova inikolova marked this pull request as draft September 1, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeyaVes TeyaVes TeyaVes approved these changes

@zhpenkov zhpenkov zhpenkov approved these changes

Assignees

@inikolova inikolova

Labels
C: List Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the ::before element inside the k-list-item-text to a different place
5 participants
@inikolova @Juveniel @TeyaVes @zhpenkov @kendo-bot