-
Notifications
You must be signed in to change notification settings - Fork 70
fix(stepper): prevent item focus indicator clipping #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Packages Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a visual clipping issue in the Stepper component where focus indicators were being cut off at high browser zoom levels (125% and 175%). The fix ensures that focus rings around current steps remain fully visible across all themes.
Key changes:
- Added
overflow: visible
to stepper container elements to prevent focus indicator clipping - Applied changes at the core level to benefit all themes consistently
- Minimal CSS-only solution that maintains backward compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this does not seem to work, try modifying the overflow style of the k-step-link element.
You were absolutely right! The issue was that Commit: 85253c2 |
c735804
to
86fdece
Compare
86fdece
to
bb7b751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
The Stepper component's active/current step indicators were being clipped at the top when browser zoom was set to 125% or 175%. This issue affected Default, Material, and Fluent themes, causing the focus ring around current steps to appear cut off.
Root Cause
The focus indicator uses a
::after
pseudo-element that extends 4px beyond the step indicator bounds using negative margins (inset-block-start: -4px
). At high zoom levels, these negative margins caused the focus indicator to be clipped by parent containers that didn't have proper overflow handling.Solution
After identifying that the
.k-step-link
element hadoverflow: hidden
, the fix was simplified to only change.k-step-link
overflow fromhidden
tovisible
in the core layout. This single, targeted change ensures focus indicators are not clipped when extending beyond normal bounds. This minimal change:Visual Comparison
Before (clipped at 175% zoom):
After (complete indicators at 175% zoom):
The fix ensures that focus indicators are fully visible at all zoom levels while maintaining the existing visual design and functionality.
Fixes #5599.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.