Merge branch 'release-1.99.0'

CHANGELOG.md

@@ -1,5 +1,38 @@
 # Changelog
 
+## v1.99.0 (15/07/2021)
+
+### Features:
+-  [#4327](https://github.com/telstra/open-kilda/pull/4327) add test for flowSLA [**tests**]
+
+### Bug Fixes:
+-  [#4288](https://github.com/telstra/open-kilda/pull/4288) Fix link properties validation (Issue: [#4161](https://github.com/telstra/open-kilda/issues/4161)) [**storm-topologies**]
+-  [#4303](https://github.com/telstra/open-kilda/pull/4303) Fix the missing cache errors in Stats caused by partial flow updates (Issue: [#4246](https://github.com/telstra/open-kilda/issues/4246)) [**storm-topologies**]
+-  [#4368](https://github.com/telstra/open-kilda/pull/4368) Fix/build issues in UI [**gui**]
+-  [#4346](https://github.com/telstra/open-kilda/pull/4346) Fix feature toggles (Issues: [#2441](https://github.com/telstra/open-kilda/issues/2441) [#4345](https://github.com/telstra/open-kilda/issues/4345)) [**storm-topologies**]
+
+### Improvements:
+-  [#4357](https://github.com/telstra/open-kilda/pull/4357) fix assertPortIsStable in PortAntiflapHelper [**tests**]
+-  [#4358](https://github.com/telstra/open-kilda/pull/4358) unignore test according to  #4271 [**tests**]
+-  [#4359](https://github.com/telstra/open-kilda/pull/4359) Minor typos fixed in tests [**tests**]
+-  [#4360](https://github.com/telstra/open-kilda/pull/4360) Force ordering of flow's history events
+-  [#4364](https://github.com/telstra/open-kilda/pull/4364) reduce latencyUpdateInterval for local func-tests [**tests**]
+-  [#4341](https://github.com/telstra/open-kilda/pull/4341) Add func tests for strict_bandwidth feature [**tests**]
+-  [#4343](https://github.com/telstra/open-kilda/pull/4343) Fix 'make test-topology' command [**tests**]
+-  [#4349](https://github.com/telstra/open-kilda/pull/4349) unignore according to #4317 [**tests**]
+-  [#4351](https://github.com/telstra/open-kilda/pull/4351) Add validation of OrientDB connections in the graph factory [**storm-topologies**]
+
+
+For the complete list of changes, check out [the commit log](https://github.com/telstra/open-kilda/compare/v1.98.0...v1.99.0).
+
+### Affected Components:
+flow-hs, gui, stats, network, orientdb, connected, reroute, ping, isllatency, nbworker, swmanager, flow-monitor
+
+### Upgrade notes:
+OrientDB schema have been changed in this release. You need to apply schema migration. Please follow [migration instructions](https://github.com/telstra/open-kilda/tree/develop/docker/db-migration/migrations).
+
+---
+
 ## v1.98.0 (02/07/2021)
 
 ### Features:

confd/templates/atdd-staging/kilda.properties.tmpl

@@ -84,3 +84,5 @@ latency.discovery.interval.multiplier = {{ getv "/kilda_latency_discovery_interv
 
 flow.ping.interval=5
 docker.host=localhost
+
+latency.update.interval = {{ getv "/kilda_latency_update_interval" }}

confd/templates/makefile/makefile.tmpl

@@ -143,5 +143,5 @@ run-func-tests:
 #   make func-tests PARAMS='--tests LinkSpec."Unable to delete an active link"'  // run a certain test from 'LinkSpec' class
 # test-topology creates a virtual topology ready for testing, ensures that it is properly discovered
 test-topology: TASK=runTest
-test-topology: PARAMS=--tests HealthCheckSpecification
+test-topology: PARAMS=--tests GenerateTopologyConfig
 func-tests test-topology: copy-test-props run-func-tests

confd/vars/main.yaml

@@ -152,7 +152,7 @@ kilda_grpc_password: "kilda"
 kilda_grpc_remote_log_server_ip: "1.1.1.1"
 kilda_grpc_remote_log_server_port: 321
 
-kilda_latency_update_interval: 300
+kilda_latency_update_interval: 120
 kilda_latency_update_time_range: 600
 kilda_latency_discovery_interval_multiplier: 3
 

docker/db-migration/migrations/008-add-kilda-feature-toggles-class.yaml

@@ -0,0 +1,26 @@
+databaseChangeLog:
+  - changeSet:
+      id: tag
+      author: dpoltavets
+      changes:
+        - tagDatabase:
+            tag: 008-add-kilda-feature-toggles-class
+
+  - changeSet:
+      id: add_kilda_feature_toggles_class
+      author: dpoltavets
+      changes:
+        - sql: "CREATE CLASS kilda_feature_toggles IF NOT EXISTS EXTENDS V"
+        - sql: "CREATE PROPERTY kilda_feature_toggles.unique IF NOT EXISTS STRING"
+        - sql: "CREATE INDEX kilda_feature_toggles.unique UNIQUE_HASH_INDEX"
+        - sql: "INSERT INTO kilda_feature_toggles FROM (SELECT FROM config)"
+        - sql: "UPDATE kilda_feature_toggles SET unique='kilda_feature_toggles'"
+        - sql: "CREATE PROPERTY kilda_configuration.unique_ex IF NOT EXISTS STRING"
+        - sql: "CREATE INDEX kilda_configuration.unique_ex UNIQUE_HASH_INDEX"
+        - sql: "UPDATE kilda_configuration SET unique_ex='kilda_configuration'"
+      rollback:
+        - sql: "DELETE VERTEX kilda_feature_toggles"
+        - sql: "DROP CLASS kilda_feature_toggles"
+        - sql: "DROP INDEX kilda_configuration.unique_ex"
+        - sql: "UPDATE kilda_configuration REMOVE unique_ex"
+        - sql: "DROP PROPERTY kilda_configuration.unique_ex"

docker/db-migration/migrations/root.yaml

@@ -33,3 +33,6 @@ databaseChangeLog:
   - include:
       relativeToChangelogFile: true
       file: 007-add-flow-strict-bandwidth-property.yaml
+  - include:
+      relativeToChangelogFile: true
+      file: 008-add-kilda-feature-toggles-class.yaml

src-gui/ui/src/browserslist → src-gui/ui/browserslist

@@ -1,9 +1,9 @@
-# This file is currently used by autoprefixer to adjust CSS to support the below specified browsers
-# For additional information regarding the format and rule options, please see:
-# https://github.com/browserslist/browserslist#queries
-# For IE 9-11 support, please uncomment the last line of the file and adjust as needed
-> 0.5%
-last 2 versions
-Firefox ESR
-not dead
+# This file is currently used by autoprefixer to adjust CSS to support the below specified browsers
+# For additional information regarding the format and rule options, please see:
+# https://github.com/browserslist/browserslist#queries
+# For IE 9-11 support, please uncomment the last line of the file and adjust as needed
+> 0.5%
+last 2 versions
+Firefox ESR
+not dead
 # IE 9-11

src-gui/ui/package.json

@@ -11,16 +11,15 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "^6.1.6",
+    "@angular/animations": "^8.2.14",
     "@angular/cdk": "^6.4.7",
-    "@angular/common": "^6.1.0",
-    "@angular/compiler": "^6.1.0",
-    "@angular/core": "^6.1.0",
-    "@angular/forms": "^6.1.0",
-    "@angular/http": "^6.1.0",
-    "@angular/platform-browser": "^6.1.0",
-    "@angular/platform-browser-dynamic": "^6.1.0",
-    "@angular/router": "^6.1.0",
+    "@angular/common": "^8.2.14",
+    "@angular/compiler": "^8.2.14",
+    "@angular/core": "^8.2.14",
+    "@angular/forms": "^8.2.14",
+    "@angular/platform-browser": "^8.2.14",
+    "@angular/platform-browser-dynamic": "^8.2.14",
+    "@angular/router": "^8.2.14",
     "@ng-bootstrap/ng-bootstrap": "^3.2.0",
     "@ng-select/ng-select": "^2.8.0",
     "@types/d3": "^4.13.0",
@@ -44,30 +43,30 @@
     "ng-click-outside": "^4.0.0",
     "ng-dygraphs": "^0.4.0",
     "ng-select2-component": "^6.0.1",
-    "ngx-clipboard": "^11.1.7",
+    "ngx-clipboard": "^12.3.1",
     "ngx-contextmenu": "5.0.3",
     "ngx-moment": "^3.1.0",
     "ngx-spinner": "^7.1.4",
     "ngx-toastr": "^9.0.2",
     "ngx-typeahead": "^6.0.0",
-    "ol": "^6.4.3",
+    "ol": "6.3.1",
     "open-iconic": "^1.1.1",
-    "rxjs": "6.3.3",
+    "rxjs": "6.6.7",
     "tslib": "^1.9.0",
-    "zone.js": "~0.8.26"
+    "zone.js": "~0.9.1"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "~0.12.0",
-    "@angular/cli": "~7.2.3",
-    "@angular/compiler-cli": "^6.1.10",
-    "@angular/language-service": "^6.1.0",
+    "@angular-devkit/build-angular": "~0.803.29",
+    "@angular/cli": "~8.3.29",
+    "@angular/compiler-cli": "^8.2.14",
+    "@angular/language-service": "^8.2.14",
     "@types/datatables.net": "^1.10.13",
     "@types/datatables.net-buttons": "^1.4.0",
     "@types/jasmine": "~2.8.6",
     "@types/jasminewd2": "~2.0.3",
     "@types/jquery": "^3.3.6",
     "@types/node": "~8.9.4",
-    "codelyzer": "~4.2.1",
+    "codelyzer": "^5.0.1",
     "jasmine-core": "~2.99.1",
     "jasmine-spec-reporter": "~4.2.1",
     "karma": "^4.4.1",
@@ -78,6 +77,6 @@
     "protractor": "~5.4.0",
     "ts-node": "~5.0.1",
     "tslint": "~5.9.1",
-    "typescript": "~2.7.2"
+    "typescript": "~3.5.3"
   }
 }

src-gui/ui/src/app/common/components/otp/otp.component.ts

@@ -19,7 +19,7 @@ export class OtpComponent implements OnInit {
   submitted = false;
   @Output()
   emitService = new EventEmitter();
-  @ViewChild("otpcontainer")
+  @ViewChild("otpcontainer", { static: true })
   otpContainerElement: ElementRef;
 
   constructor(

src-gui/ui/src/app/common/data-models/isl-model.ts

@@ -1,4 +1,3 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
 
 export interface IslModel {
     src_port: number,

src-gui/ui/src/app/common/data-models/permission.ts

@@ -1,4 +1,4 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
+
 import { Role } from "./role";
 
 export interface Permission {

src-gui/ui/src/app/common/data-models/role.ts

@@ -1,4 +1,4 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
+
 import { Permission } from './permission';
 import { User } from "./user";
 

src-gui/ui/src/app/common/data-models/switch.ts

@@ -1,4 +1,3 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
 
 export interface Switch {
     switch_id: string;

src-gui/ui/src/app/common/data-models/topology-view.ts

@@ -1,4 +1,4 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
+
 
 export interface TopologyView {
     SWITCH_CHECKED: number,

src-gui/ui/src/app/common/data-models/user.ts

@@ -1,4 +1,4 @@
-import { NULL_INJECTOR } from "@angular/core/src/render3/component";
+
 import { Role } from './role';
 import { Permission } from "./permission";
 

src-gui/ui/src/app/modules/flows/flow-contracts/flow-contracts.component.ts

@@ -14,7 +14,7 @@ import { MessageObj } from 'src/app/common/constants/constants';
   styleUrls: ['./flow-contracts.component.css']
 })
 export class FlowContractsComponent implements OnInit,OnChanges, AfterViewInit {
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   dtOptions = {};
   dtTrigger: Subject<any> = new Subject();
   @Input() data = [];

src-gui/ui/src/app/modules/flows/flow-datatables/flow-datatables.component.ts

@@ -19,7 +19,7 @@ import { MessageObj } from 'src/app/common/constants/constants';
   styleUrls: ['./flow-datatables.component.css']
 })
 export class FlowDatatablesComponent implements OnInit, AfterViewInit, OnChanges, OnDestroy {
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   @Input() data = [];
   @Input() srcSwitch : string;
   @Input() dstSwitch : string;

src-gui/ui/src/app/modules/flows/flow-list/flow-list.component.ts

@@ -20,7 +20,7 @@ import { CommonService } from 'src/app/common/services/common.service';
 export class FlowListComponent implements OnDestroy, OnInit, OnChanges, AfterViewInit{
   @Input() srcSwitch : string;
   @Input() dstSwitch : string;
-  @ViewChild(FlowDatatablesComponent) childFlowComponent:FlowDatatablesComponent;
+  @ViewChild(FlowDatatablesComponent, { static: false }) childFlowComponent:FlowDatatablesComponent;
 
   dataSet: any;
 

src-gui/ui/src/app/modules/isl/datatable/datatable.component.ts

@@ -21,7 +21,6 @@ import { DataTableDirective } from "angular-datatables";
 import { ToastrService } from "ngx-toastr";
 import { NgxSpinnerService } from "ngx-spinner";
 import { LoaderService } from "../../../common/services/loader.service";
-import { Renderer3 } from "@angular/core/src/render3/interfaces/renderer";
 import { ClipboardService } from "ngx-clipboard";
 
 @Component({
@@ -30,7 +29,7 @@ import { ClipboardService } from "ngx-clipboard";
   styleUrls: ["./datatable.component.css"]
 })
 export class DatatableComponent implements OnDestroy, OnInit, AfterViewInit, OnChanges {
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   dtOptions: any = {};
   dtTrigger: Subject<any> = new Subject();
 

src-gui/ui/src/app/modules/isl/isl-flow-datatables/isl-flow-datatables.component.ts

@@ -14,7 +14,7 @@ import { MessageObj } from 'src/app/common/constants/constants';
   styleUrls: ['./isl-flow-datatables.component.css']
 })
 export class IslFlowDatatablesComponent implements OnInit , AfterViewInit , OnDestroy  {
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   @Input() data = [];
   @Input() srcSwitch : string;
   @Input() dstSwitch : string;

src-gui/ui/src/app/modules/reports/affected-flow-list/affected-flow-list.component.ts

@@ -19,7 +19,7 @@ import { MessageObj } from 'src/app/common/constants/constants';
   styleUrls: ['./affected-flow-list.component.css']
 })
 export class AffectedFlowListComponent implements OnInit, AfterViewInit, OnChanges, OnDestroy {
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   @Input() data = [];
   @Input() textSearch:any;
   @Output() refresh =  new EventEmitter();

src-gui/ui/src/app/modules/reports/affected-flows-report/affected-flows-report.component.ts

@@ -19,7 +19,7 @@ import { CommonService } from 'src/app/common/services/common.service';
 export class AffectedFlowsReportComponent  implements OnDestroy, OnInit, OnChanges, AfterViewInit{
   @Input() srcSwitch : string;
   @Input() dstSwitch : string;
-  @ViewChild(AffectedFlowListComponent) childFlowComponent:AffectedFlowListComponent;
+  @ViewChild(AffectedFlowListComponent, { static: false }) childFlowComponent:AffectedFlowListComponent;
 
   dataSet: any;
 

src-gui/ui/src/app/modules/settings/saml-edit/saml-edit.component.ts

@@ -18,7 +18,7 @@ export class SamlEditComponent implements OnInit,OnChanges {
   @Input() data:any;
   @Output() cancel =  new EventEmitter();
 
-  @ViewChild("file")
+  @ViewChild("file", { static: true })
   fileElementRef: ElementRef;
   uuid:any=null;
   files:FileList;

src-gui/ui/src/app/modules/settings/saml-list-table/saml-list-table.component.ts

@@ -12,7 +12,7 @@ import { Subject } from 'rxjs';
 })
 export class SamlListTableComponent implements OnInit , OnChanges{
 
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   @Input() data=[];
   @Output() editsaml = new EventEmitter();
   @Output() deletesaml = new EventEmitter();

src-gui/ui/src/app/modules/switches/port-flows/port-flows.component.ts

@@ -13,7 +13,7 @@ declare var jQuery: any;
   styleUrls: ['./port-flows.component.css']
 })
 export class PortFlowsComponent implements  OnDestroy, OnInit,OnChanges, AfterViewInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   datatableElement: DataTableDirective;
   @Input() data;
   @Input() textSearch:any;

src-gui/ui/src/app/modules/switches/port-inventory-flows/port-inventory-flows.component.ts

@@ -14,7 +14,7 @@ declare var jQuery: any;
   styleUrls: ['./port-inventory-flows.component.css']
 })
 export class PortInventoryFlowsComponent implements  OnDestroy, OnInit,OnChanges, AfterViewInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   datatableElement: DataTableDirective;
   @Input() data;  
   @Input() textSearch:any;

src-gui/ui/src/app/modules/switches/port-list/port-list.component.ts

@@ -16,7 +16,7 @@ import { CommonService } from 'src/app/common/services/common.service';
   styleUrls: ['./port-list.component.css']
 })
 export class PortListComponent implements OnInit, AfterViewInit, OnDestroy, OnChanges {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   dtElement: DataTableDirective;
   @Input() switch = null;
   @Input() loadinterval = false

src-gui/ui/src/app/modules/switches/switch-datatable/switch-datatable.component.ts

@@ -19,7 +19,7 @@ declare var jQuery: any;
 })
 export class SwitchDatatableComponent implements OnInit, OnChanges,OnDestroy,AfterViewInit {
 
-  @ViewChild(DataTableDirective)  datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true })  datatableElement: DataTableDirective;
   @Input() data =[];
   @Input() switchFilterFlag:string;  
   @Input() textSearch:any;

src-gui/ui/src/app/modules/switches/switch-flows/switch-flows.component.ts

@@ -17,7 +17,7 @@ declare var jQuery: any;
 })
 export class SwitchFlowsComponent implements OnDestroy, OnInit,OnChanges, AfterViewInit {
 
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   datatableElement: DataTableDirective;
   @Input() data;
   @Output() refresh =  new EventEmitter();

src-gui/ui/src/app/modules/topology/failed-isl/failed-isl.component.ts

@@ -10,7 +10,7 @@ import { TopologyService } from 'src/app/common/services/topology.service';
   styleUrls: ['./failed-isl.component.css']
 })
 export class FailedIslComponent implements OnInit, AfterViewInit, OnDestroy {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   datatableElement: DataTableDirective;
   dtOptions: any = {};
   dtTrigger: Subject<any> = new Subject();

src-gui/ui/src/app/modules/topology/unidirectional-isl/unidirectional-isl.component.ts

@@ -10,7 +10,7 @@ import { TopologyService } from 'src/app/common/services/topology.service';
   styleUrls: ['./unidirectional-isl.component.css']
 })
 export class UnidirectionalIslComponent implements OnInit, AfterViewInit, OnDestroy {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
   datatableElement: DataTableDirective;
   dtOptions:any =  {};
   dtTrigger: Subject<any> = new Subject();

src-gui/ui/src/app/modules/useractivity/useractivity-list/useractivity-list.component.ts

@@ -9,7 +9,7 @@ import { LoaderService } from 'src/app/common/services/loader.service';
 })
 export class UseractivityListComponent implements OnInit,OnChanges {
 
-  @ViewChild(DataTableDirective) datatableElement: DataTableDirective;
+  @ViewChild(DataTableDirective, { static: true }) datatableElement: DataTableDirective;
   @Input() data=[];
   dtOptions = {};  
   wrapperHide=true;

src-gui/ui/src/app/modules/usermanagement/permissions/permission-list/permission-list.component.ts

@@ -17,7 +17,7 @@ import { MessageObj } from 'src/app/common/constants/constants';
   styleUrls: ['./permission-list.component.css']
 })
 export class PermissionListComponent implements OnDestroy, OnInit, AfterViewInit {
-  @ViewChild(DataTableDirective)
+  @ViewChild(DataTableDirective, { static: true })
 
   datatableElement: DataTableDirective;
   dtOptions : any = {};