-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate pod-init into operator chart, add testing #383
base: main
Are you sure you want to change the base?
Conversation
1ada3c1 to
bffee92
Compare
|
This is ready to start the review process. Things to note:
|
sjmiller609
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think we just need to look out for the upgrade concerns, so let's sync on that tomorrow and plan out how to roll it out
| - name: Install kind cluster | ||
| uses: helm/[email protected] | ||
| with: | ||
| install_only: true | ||
| - name: Start kind cluster | ||
| run: just start-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two steps look like they are doing the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kind-action installs the kind binary into the step, the just start-kind sets up the cluster.
charts/tembo-operator/Chart.lock
Outdated
| dependencies: | ||
| - name: cloudnative-pg | ||
| repository: https://cloudnative-pg.github.io/charts | ||
| version: 0.18.2 | ||
| digest: sha256:a2958964e5a652da7ad60263bb0a68e01481da5d642c779462aeaf9450bc208a | ||
| generated: "2023-11-10T15:17:24.580704853-06:00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder - let's discuss cut-over plan for internal. Like since this is installed in another way internally, how to switch over our argo configs for this
| apiVersion: v2 | ||
| name: coredb-operator | ||
| description: Helm chart to deploy coredb operator | ||
| name: tembo-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for cut-over, we need to consider how to do this gracefully, I think just the workload going down and coming back works but we need to check on changing the helm ownership and ensuring safe cut over of the CRDs
b14d7b7 to
5f7e737
Compare
5f7e737 to
ba9739e
Compare
This PR changes how the
tembo-operatorhelm chart is installed. This is meant to improve end user experience using the operator helm chart. This PR changes the following:pod-initandcontrollerportions along with the CNPG operator as a dependency into the same namespace. TEM-2034tembo-pod-inithelm chart.