Skip to content
This repository was archived by the owner on Dec 5, 2023. It is now read-only.

Conversation

@nhudson
Copy link
Contributor

@nhudson nhudson commented Nov 13, 2023

This PR changes how the tembo-operator helm chart is installed. This is meant to improve end user experience using the operator helm chart. This PR changes the following:

  • Operator chart now installs 2 main components (controller & pod-init) and 1 dependency component (CNPG) TEM-2033
  • The chart installs pod-init and controller portions along with the CNPG operator as a dependency into the same namespace. TEM-2034
  • Basic docs added to README
  • CI/CD linting and testing using chart-testing
  • Deprecate the tembo-pod-init helm chart.

@nhudson nhudson self-assigned this Nov 13, 2023
@nhudson nhudson force-pushed the nhudson/TEM-2034 branch 2 times, most recently from 1ada3c1 to bffee92 Compare November 19, 2023 21:54
@nhudson nhudson marked this pull request as ready for review November 20, 2023 14:06
@nhudson
Copy link
Contributor Author

nhudson commented Nov 20, 2023

This is ready to start the review process. Things to note:

  • I need to figure out if we need to generate a new GitHub Token to publish the charts

  • More testing is needed to make sure we check the chart for version bumps if there are changes. Right now it checks what is in main but since it's not there yet, it fails the check. So for now it's commented out.

  • I want to walk through the process of making sure our deployments are updated correctly before we merge this. The ArgoCD deployments will fail due to the number of changes in the charts.

Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we just need to look out for the upgrade concerns, so let's sync on that tomorrow and plan out how to roll it out

Comment on lines +112 to +117
- name: Install kind cluster
uses: helm/[email protected]
with:
install_only: true
- name: Start kind cluster
run: just start-kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two steps look like they are doing the same thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kind-action installs the kind binary into the step, the just start-kind sets up the cluster.

Comment on lines 1 to 6
dependencies:
- name: cloudnative-pg
repository: https://cloudnative-pg.github.io/charts
version: 0.18.2
digest: sha256:a2958964e5a652da7ad60263bb0a68e01481da5d642c779462aeaf9450bc208a
generated: "2023-11-10T15:17:24.580704853-06:00"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder - let's discuss cut-over plan for internal. Like since this is installed in another way internally, how to switch over our argo configs for this

apiVersion: v2
name: coredb-operator
description: Helm chart to deploy coredb operator
name: tembo-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for cut-over, we need to consider how to do this gracefully, I think just the workload going down and coming back works but we need to check on changing the helm ownership and ensuring safe cut over of the CRDs

@nhudson nhudson requested a review from ChuckHend as a code owner November 21, 2023 11:12
@nhudson nhudson force-pushed the nhudson/TEM-2034 branch 2 times, most recently from b14d7b7 to 5f7e737 Compare November 22, 2023 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants