Add GetAuditLogs API #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jul 18, 2024
cretz
reviewed
Jul 19, 2024
anekkanti
reviewed
Jul 19, 2024
anekkanti
reviewed
Jul 19, 2024
|
Resolved comments based on internal discussions as updating schema is not part of this release. |
|
Ah, I think my approval is based on the ability to review the fields and their names, but if not and they are set, can bypass the need for my approval here and get others' approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added API spec for GetAuditLogs, includes Audit Log format as auditlog.v1.LogRecord
Why?
To enable GetAuditLogs handler, and define public schema for Audit Logs
Checklist
make protoCloses
How was this tested: