GHA to create tags/releases #170
Open
+188
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Blindly bumping api-go is not recommended. Firstly, rarely do users use this without SDK, and the SDK needs to be vetted on the API bump. Secondly, it makes assumptions about where people's go.mod's live which is not necessarily accurate either. If a certain repo wants some automation to bump a certain dependency it has, that automation should be in that repo IMO, not this shared one.
|
Can you give some background on the savings here on starting a GH workflow vs publishing release in GH? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
GHA to create tag and releases.
If a release is created, it also creates a PR in the consumers of api-go for review.
Why?
Automation.
How did you test it?
Potential risks