Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow_start_delay to StartChildWorkflowExecutionCommand #441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add workflow_start_delay to StartChildWorkflowExecutionCommand #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4dde2
add workflow_start_delay to StartChildWorkflowExecutionCommand
lina-temporal Aug 7, 2024
839ebbe
Remove incorrect docs about signaling workflows with start delay
lina-temporal Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5455,7 +5455,7 @@
},
"workflowStartDelay": {
"type": "string",
"description": "Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`.\nIf the workflow gets a signal before the delay, a workflow task will be dispatched and the rest\nof the delay will be ignored."
"description": "Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`."
},
"completionCallbacks": {
"type": "array",
Expand Down Expand Up @@ -10208,6 +10208,10 @@
"inheritBuildId": {
"type": "boolean",
"description": "If this is set, the child workflow inherits the Build ID of the parent. Otherwise, the assignment\nrules of the child's Task Queue will be used to independently assign a Build ID to it."
},
"workflowStartDelay": {
"type": "string",
"description": "Time to wait before dispatching the child workflow's first task. Cannot\nbe used with `cron_schedule`."
}
}
},
Expand Down Expand Up @@ -10325,6 +10329,10 @@
"inheritBuildId": {
"type": "boolean",
"description": "If this is set, the child workflow inherits the Build ID of the parent. Otherwise, the assignment\nrules of the child's Task Queue will be used to independently assign a Build ID to it."
},
"workflowStartDelay": {
"type": "string",
"description": "Time to wait before dispatching the child workflow's first task. Cannot\nbe used with `cron_schedule`."
}
}
},
Expand Down Expand Up @@ -10480,7 +10488,7 @@
},
"workflowStartDelay": {
"type": "string",
"description": "Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`.\nIf the workflow gets a signal before the delay, a workflow task will be dispatched and the rest\nof the delay will be ignored."
"description": "Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`."
},
"completionCallbacks": {
"type": "array",
Expand Down
11 changes: 7 additions & 4 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7925,6 +7925,12 @@ components:
description: |-
If this is set, the child workflow inherits the Build ID of the parent. Otherwise, the assignment
rules of the child's Task Queue will be used to independently assign a Build ID to it.
workflowStartDelay:
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
type: string
description: |-
Time to wait before dispatching the child workflow's first task. Cannot
be used with `cron_schedule`.
StartWorkflowExecutionRequest:
type: object
properties:
Expand Down Expand Up @@ -8018,10 +8024,7 @@ components:
workflowStartDelay:
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
type: string
description: |-
Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`.
If the workflow gets a signal before the delay, a workflow task will be dispatched and the rest
of the delay will be ignored.
description: Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`.
completionCallbacks:
type: array
items:
Expand Down
3 changes: 3 additions & 0 deletions temporal/api/command/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ message StartChildWorkflowExecutionCommandAttributes {
// If this is set, the child workflow inherits the Build ID of the parent. Otherwise, the assignment
// rules of the child's Task Queue will be used to independently assign a Build ID to it.
bool inherit_build_id = 17;
// Time to wait before dispatching the child workflow's first task. Cannot
// be used with `cron_schedule`.
google.protobuf.Duration workflow_start_delay = 18;
}

message ProtocolMessageCommandAttributes {
Expand Down
3 changes: 3 additions & 0 deletions temporal/api/history/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,9 @@ message StartChildWorkflowExecutionInitiatedEventAttributes {
// If this is set, the child workflow inherits the Build ID of the parent. Otherwise, the assignment
// rules of the child's Task Queue will be used to independently assign a Build ID to it.
bool inherit_build_id = 19;
// Time to wait before dispatching the child workflow's first task. Cannot
// be used with `cron_schedule`.
google.protobuf.Duration workflow_start_delay = 20;
}

message StartChildWorkflowExecutionFailedEventAttributes {
Expand Down
2 changes: 0 additions & 2 deletions temporal/api/workflowservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,6 @@ message StartWorkflowExecutionRequest {
temporal.api.failure.v1.Failure continued_failure = 18;
temporal.api.common.v1.Payloads last_completion_result = 19;
// Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`.
// If the workflow gets a signal before the delay, a workflow task will be dispatched and the rest
// of the delay will be ignored.
google.protobuf.Duration workflow_start_delay = 20;
// Callbacks to be called by the server when this workflow reaches a terminal state.
// If the workflow continues-as-new, these callbacks will be carried over to the new execution.
Expand Down
Loading