Skip to content

Add lease duration to worker heartbeat request #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add lease duration to worker heartbeat request #661

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb018d2
Add lease duration to worker heartbeat request
rkannan82 Nov 11, 2025
8db1c11
Update openapi defs
rkannan82 Nov 11, 2025
a92e463
Add more comments
rkannan82 Nov 12, 2025
ee6f922
Clarify semantics of non retryable error in cleanedup state.
rkannan82 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8125,6 +8125,10 @@
"type": "object",
"$ref": "#/definitions/v1WorkerHeartbeat"
}
},
"leaseDuration": {
"type": "string",
"description": "Duration for which the worker lease should be valid.\nServer will calculate the actual expiration time based on when it receives this request.\nIf not specified or zero, the server will use a default lease duration (typically 60 seconds)."
}
}
},
Expand Down
7 changes: 7 additions & 0 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10355,6 +10355,13 @@ components:
type: array
items:
$ref: '#/components/schemas/WorkerHeartbeat'
leaseDuration:
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
type: string
description: |-
Duration for which the worker lease should be valid.
Server will calculate the actual expiration time based on when it receives this request.
If not specified or zero, the server will use a default lease duration (typically 60 seconds).
RecordWorkerHeartbeatResponse:
type: object
properties: {}
Expand Down
5 changes: 5 additions & 0 deletions temporal/api/workflowservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,6 +2467,11 @@ message RecordWorkerHeartbeatRequest {
string identity = 2;

repeated temporal.api.worker.v1.WorkerHeartbeat worker_heartbeat = 3;

// Duration for which the worker lease should be valid.
// Server will calculate the actual expiration time based on when it receives this request.
// If not specified or zero, the server will use a default lease duration (typically 60 seconds).
google.protobuf.Duration lease_duration = 4;
}

message RecordWorkerHeartbeatResponse {
Expand Down
Loading