Add new options to reset/update activities #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Spencer Judge <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Thomas Hardy <[email protected]> Co-authored-by: Jacob Barzee <[email protected]> Co-authored-by: Rodrigo Zhou <[email protected]>
Co-authored-by: Spencer Judge <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Thomas Hardy <[email protected]> Co-authored-by: Jacob Barzee <[email protected]> Co-authored-by: Rodrigo Zhou <[email protected]> Co-authored-by: Dan Davison <[email protected]> Co-authored-by: Andrew Yuan <[email protected]> Co-authored-by: Chad Retz <[email protected]>
## What was changed WISOTT
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Print Nexus callbacks links in DescribeWorkflowExecution <img width="1756" alt="Screenshot 2025-05-02 at 11 05 21" src="https://github.com/user-attachments/assets/30c41d5f-2643-4b24-867e-1a161622c6af" /> ## Why? <!-- Tell your future self why have you made these changes --> ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR!
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->
<!--- For ALL Contributors 👇 -->
## What was changed
<!-- Describe what has changed in this PR -->
## Why?
<!-- Tell your future self why have you made these changes -->
## Checklist
<!--- add/delete as needed --->
1. Closes <!-- add issue number here -->
2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
cretz
reviewed
Jun 2, 2025
Note. |
👍 This is good so that we can add tests. However, since this is likely no rush since there's no released server to use this with, I think we should wait to merge until we can update go.mod with a server tag. If figure this will be quite soon anyways. |
tests are added.
This is merge to |
|
@ychebotarev - can likely update dependencies to stable tags now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
temporal activity resetandtemporal activity update-optionsWhy?
Users should be able to restore original activity options.